Subject: [PATCH v6 2/2] phy: cadence-torrent: Set Torrent PHY attributes

Set Torrent PHY attributes bus_width, max_link_rate and mode
for DisplayPort.

Signed-off-by: Swapnil Jakhade <[email protected]>
Acked-by: Kishon Vijay Abraham I <[email protected]>
---
drivers/phy/cadence/phy-cadence-torrent.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c
index 7116127358ee..116aca36f7dd 100644
--- a/drivers/phy/cadence/phy-cadence-torrent.c
+++ b/drivers/phy/cadence/phy-cadence-torrent.c
@@ -1852,6 +1852,10 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev)
cdns_phy->phys[node].num_lanes,
cdns_phy->max_bit_rate / 1000,
cdns_phy->max_bit_rate % 1000);
+
+ gphy->attrs.bus_width = cdns_phy->phys[node].num_lanes;
+ gphy->attrs.max_link_rate = cdns_phy->max_bit_rate;
+ gphy->attrs.mode = PHY_MODE_DP;
} else {
dev_err(dev, "Driver supports only PHY_TYPE_DP\n");
ret = -ENOTSUPP;
--
2.26.1


2020-09-15 23:03:13

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH v6 2/2] phy: cadence-torrent: Set Torrent PHY attributes

Hi Swapnil,

Thank you for the patch.

On Fri, Sep 11, 2020 at 08:18:34AM +0200, Swapnil Jakhade wrote:
> Set Torrent PHY attributes bus_width, max_link_rate and mode
> for DisplayPort.
>
> Signed-off-by: Swapnil Jakhade <[email protected]>
> Acked-by: Kishon Vijay Abraham I <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/phy/cadence/phy-cadence-torrent.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c
> index 7116127358ee..116aca36f7dd 100644
> --- a/drivers/phy/cadence/phy-cadence-torrent.c
> +++ b/drivers/phy/cadence/phy-cadence-torrent.c
> @@ -1852,6 +1852,10 @@ static int cdns_torrent_phy_probe(struct platform_device *pdev)
> cdns_phy->phys[node].num_lanes,
> cdns_phy->max_bit_rate / 1000,
> cdns_phy->max_bit_rate % 1000);
> +
> + gphy->attrs.bus_width = cdns_phy->phys[node].num_lanes;
> + gphy->attrs.max_link_rate = cdns_phy->max_bit_rate;
> + gphy->attrs.mode = PHY_MODE_DP;
> } else {
> dev_err(dev, "Driver supports only PHY_TYPE_DP\n");
> ret = -ENOTSUPP;

--
Regards,

Laurent Pinchart