2020-09-16 18:41:24

by Yue Haibing

Subject: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static

Fix sparse warning:

fs/btrfs/sysfs.c:1386:5: warning:
symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
fs/btrfs/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index e7b0e10685d9..279d9262b676 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1383,7 +1383,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
return ret;
}

-int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
+static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
{
int ret;
struct btrfs_device *device;
--
2.17.1

2020-09-17 05:39:23

by Anand Jain

Subject: Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static

On 16/9/20 10:26 pm, YueHaibing wrote:
> Fix sparse warning:
>
> fs/btrfs/sysfs.c:1386:5: warning:
> symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?


misc-next branch has it declared static. It was fixed later.

Thanks, Anand


>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> fs/btrfs/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index e7b0e10685d9..279d9262b676 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -1383,7 +1383,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
> return ret;
> }
>
> -int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> +static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> {
> int ret;
> struct btrfs_device *device;
>

2020-09-17 12:59:46

by David Sterba

Subject: Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static

On Thu, Sep 17, 2020 at 09:47:24AM +0800, Anand Jain wrote:
>
>
>
> On 16/9/20 10:26 pm, YueHaibing wrote:
> > Fix sparse warning:
> >
> > fs/btrfs/sysfs.c:1386:5: warning:
> > symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?
>
>
> misc-next branch has it declared static. It was fixed later.

Yeah it's fixed, the k.org for-next got a bit behind the snapshot
branches, I'll do an update today.