2020-09-17 03:54:27

by Dawning

Subject: [PATCH v1] atomisp:pci/runtime/queue: modify the return error value

modify the return error value is -EDOM

Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
Cc: Evan Quan <[email protected]>
Signed-off-by: Xiaoliang Pang <[email protected]>
---
.../staging/media/atomisp/pci/runtime/queue/src/queue_access.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
index fdca743c4ab7..424e7a15a389 100644
--- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
+++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
@@ -44,7 +44,7 @@ int ia_css_queue_load(
the value as zero. This causes division by 0
exception as the size is used in a modular
division operation. */
- return EDOM;
+ return -EDOM;
}
}

--
2.17.1

2020-09-17 05:33:41

by Tianjia Zhang

Subject: Re: [PATCH v1] atomisp:pci/runtime/queue: modify the return error value

LGTM.

Reviewed-by: Tianjia Zhang <[email protected]>

On 9/17/20 11:44 AM, Xiaoliang Pang wrote:
> modify the return error value is -EDOM
>
> Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
> Cc: Evan Quan <[email protected]>
> Signed-off-by: Xiaoliang Pang <[email protected]>
> ---
> .../staging/media/atomisp/pci/runtime/queue/src/queue_access.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> index fdca743c4ab7..424e7a15a389 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> @@ -44,7 +44,7 @@ int ia_css_queue_load(
> the value as zero. This causes division by 0
> exception as the size is used in a modular
> division operation. */
> - return EDOM;
> + return -EDOM;
> }
> }
>
>