2020-09-17 13:16:54

by Jing Xiangfeng

Subject: [PATCH] fbcon: Remove the superfluous break

Remove the superfuous break, as there is a 'return' before it.

Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/video/fbdev/core/fbcon.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 0b49b0f44edf..623359aadd1e 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
vc->vc_video_erase_char,
vc->vc_size_row * count);
return true;
- break;

case SCROLL_WRAP_MOVE:
if (b - t - count > 3 * vc->vc_rows >> 2) {
@@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
vc->vc_video_erase_char,
vc->vc_size_row * count);
return true;
- break;

case SCROLL_WRAP_MOVE:
if (b - t - count > 3 * vc->vc_rows >> 2) {
--
2.17.1

2020-09-17 17:54:56

by Nick Desaulniers

Subject: Re: [PATCH] fbcon: Remove the superfluous break

On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <[email protected]> wrote:
>
> Remove the superfuous break, as there is a 'return' before it.

superfluous (missed "l")

>
> Signed-off-by: Jing Xiangfeng <[email protected]>

Reviewed-by: Nick Desaulniers <[email protected]>

Thanks for the patch; I audited the rest of the switch statements in
this translation unit; LGTM.

> ---
> drivers/video/fbdev/core/fbcon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 0b49b0f44edf..623359aadd1e 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> --
> 2.17.1
>


--
Thanks,
~Nick Desaulniers

2020-09-17 19:14:34

by Gustavo A. R. Silva

Subject: Re: [PATCH] fbcon: Remove the superfluous break

On 9/17/20 08:15, Jing Xiangfeng wrote:
> Remove the superfuous break, as there is a 'return' before it.
>
> Signed-off-by: Jing Xiangfeng <[email protected]>

Reviewed-by: Gustavo A. R. Silva <[email protected]>

Also, the following Fixes tag should be included in the changelog text:

Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")

Thanks
--
Gustavo

> ---
> drivers/video/fbdev/core/fbcon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 0b49b0f44edf..623359aadd1e 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> vc->vc_video_erase_char,
> vc->vc_size_row * count);
> return true;
> - break;
>
> case SCROLL_WRAP_MOVE:
> if (b - t - count > 3 * vc->vc_rows >> 2) {
>

2020-09-18 00:54:27

by Jing Xiangfeng

Subject: Re: [PATCH] fbcon: Remove the superfluous break

On 2020/9/18 1:36, Nick Desaulniers wrote:
> On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <[email protected]> wrote:
>>
>> Remove the superfuous break, as there is a 'return' before it.
>
> superfluous (missed "l")

Thanks for correcting!
>
>>
>> Signed-off-by: Jing Xiangfeng <[email protected]>
>
> Reviewed-by: Nick Desaulniers <[email protected]>
>
> Thanks for the patch; I audited the rest of the switch statements in
> this translation unit; LGTM.
>
>> ---
>> drivers/video/fbdev/core/fbcon.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
>> index 0b49b0f44edf..623359aadd1e 100644
>> --- a/drivers/video/fbdev/core/fbcon.c
>> +++ b/drivers/video/fbdev/core/fbcon.c
>> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>> --
>> 2.17.1
>>
>
>

2020-09-18 00:55:35

by Jing Xiangfeng

Subject: Re: [PATCH] fbcon: Remove the superfluous break

On 2020/9/18 2:52, Gustavo A. R. Silva wrote:
>
>
> On 9/17/20 08:15, Jing Xiangfeng wrote:
>> Remove the superfuous break, as there is a 'return' before it.
>>
>> Signed-off-by: Jing Xiangfeng <[email protected]>
>
> Reviewed-by: Gustavo A. R. Silva <[email protected]>
>
> Also, the following Fixes tag should be included in the changelog text:
>
> Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")

OK, I'll send a v2 with this tag.

>
> Thanks
> --
> Gustavo
>
>> ---
>> drivers/video/fbdev/core/fbcon.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
>> index 0b49b0f44edf..623359aadd1e 100644
>> --- a/drivers/video/fbdev/core/fbcon.c
>> +++ b/drivers/video/fbdev/core/fbcon.c
>> @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>> @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
>> vc->vc_video_erase_char,
>> vc->vc_size_row * count);
>> return true;
>> - break;
>>
>> case SCROLL_WRAP_MOVE:
>> if (b - t - count > 3 * vc->vc_rows >> 2) {
>>
> .
>

2020-09-18 12:45:16

by Daniel Vetter

Subject: Re: [PATCH] fbcon: Remove the superfluous break

On Fri, Sep 18, 2020 at 08:52:02AM +0800, Jing Xiangfeng wrote:
>
>
> On 2020/9/18 2:52, Gustavo A. R. Silva wrote:
> >
> >
> > On 9/17/20 08:15, Jing Xiangfeng wrote:
> > > Remove the superfuous break, as there is a 'return' before it.
> > >
> > > Signed-off-by: Jing Xiangfeng <[email protected]>
> >
> > Reviewed-by: Gustavo A. R. Silva <[email protected]>
> >
> > Also, the following Fixes tag should be included in the changelog text:
> >
> > Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
>
> OK, I'll send a v2 with this tag.

Please also collect all the r-b tags you received so I can just apply
everything.
-Daniel

>
> >
> > Thanks
> > --
> > Gustavo
> >
> > > ---
> > > drivers/video/fbdev/core/fbcon.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> > > index 0b49b0f44edf..623359aadd1e 100644
> > > --- a/drivers/video/fbdev/core/fbcon.c
> > > +++ b/drivers/video/fbdev/core/fbcon.c
> > > @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> > > vc->vc_video_erase_char,
> > > vc->vc_size_row * count);
> > > return true;
> > > - break;
> > >
> > > case SCROLL_WRAP_MOVE:
> > > if (b - t - count > 3 * vc->vc_rows >> 2) {
> > > @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> > > vc->vc_video_erase_char,
> > > vc->vc_size_row * count);
> > > return true;
> > > - break;
> > >
> > > case SCROLL_WRAP_MOVE:
> > > if (b - t - count > 3 * vc->vc_rows >> 2) {
> > >
> > .
> >

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch