2020-09-21 08:06:37

by Liu Shixin

Subject: [PATCH -next] fpga: dfl: simplify the return expression of fme_perf_pmu_register

Simplify the return expression.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/fpga/dfl-fme-perf.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
index 531266287eee..e881fbe6d838 100644
--- a/drivers/fpga/dfl-fme-perf.c
+++ b/drivers/fpga/dfl-fme-perf.c
@@ -906,7 +906,6 @@ static int fme_perf_pmu_register(struct platform_device *pdev,
{
struct pmu *pmu = &priv->pmu;
char *name;
- int ret;

spin_lock_init(&priv->fab_lock);

@@ -926,11 +925,7 @@ static int fme_perf_pmu_register(struct platform_device *pdev,

name = devm_kasprintf(priv->dev, GFP_KERNEL, "dfl_fme%d", pdev->id);

- ret = perf_pmu_register(pmu, name, -1);
- if (ret)
- return ret;
-
- return 0;
+ return perf_pmu_register(pmu, name, -1);
}

static void fme_perf_pmu_unregister(struct fme_perf_priv *priv)
--
2.25.1

2020-09-21 15:37:40

by Wu Hao

Subject: RE: [PATCH -next] fpga: dfl: simplify the return expression of fme_perf_pmu_register

> Subject: [PATCH -next] fpga: dfl: simplify the return expression of
> fme_perf_pmu_register
>
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <[email protected]>

Looks good to me.

Acked-by: Wu Hao <[email protected]>

Thanks
Hao

> ---
> drivers/fpga/dfl-fme-perf.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
> index 531266287eee..e881fbe6d838 100644
> --- a/drivers/fpga/dfl-fme-perf.c
> +++ b/drivers/fpga/dfl-fme-perf.c
> @@ -906,7 +906,6 @@ static int fme_perf_pmu_register(struct
> platform_device *pdev,
> {
> struct pmu *pmu = &priv->pmu;
> char *name;
> - int ret;
>
> spin_lock_init(&priv->fab_lock);
>
> @@ -926,11 +925,7 @@ static int fme_perf_pmu_register(struct
> platform_device *pdev,
>
> name = devm_kasprintf(priv->dev, GFP_KERNEL, "dfl_fme%d", pdev-
> >id);
>
> - ret = perf_pmu_register(pmu, name, -1);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return perf_pmu_register(pmu, name, -1);
> }
>
> static void fme_perf_pmu_unregister(struct fme_perf_priv *priv)
> --
> 2.25.1