2020-09-21 13:18:43

by Qinglang Miao

Subject: [PATCH -next] drm/panel: simplify the return expression of td028ttec1_prepare

Simplify the return expression.

Signed-off-by: Qinglang Miao <[email protected]>
---
drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
index 037c14fd6..ba0c00d1a 100644
--- a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
+++ b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
@@ -242,13 +242,8 @@ static int td028ttec1_prepare(struct drm_panel *panel)
static int td028ttec1_enable(struct drm_panel *panel)
{
struct td028ttec1_panel *lcd = to_td028ttec1_device(panel);
- int ret;

- ret = jbt_ret_write_0(lcd, JBT_REG_DISPLAY_ON, NULL);
- if (ret)
- return ret;
-
- return 0;
+ return jbt_ret_write_0(lcd, JBT_REG_DISPLAY_ON, NULL);
}

static int td028ttec1_disable(struct drm_panel *panel)
--
2.23.0

2020-09-24 19:49:38

by Sam Ravnborg

Subject: Re: [PATCH -next] drm/panel: simplify the return expression of td028ttec1_prepare

Hi Qinglang

On Mon, Sep 21, 2020 at 09:10:18PM +0800, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <[email protected]>


Thanks, applied to drm-misc-next.

Sam

> ---
> drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
> index 037c14fd6..ba0c00d1a 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c
> @@ -242,13 +242,8 @@ static int td028ttec1_prepare(struct drm_panel *panel)
> static int td028ttec1_enable(struct drm_panel *panel)
> {
> struct td028ttec1_panel *lcd = to_td028ttec1_device(panel);
> - int ret;
>
> - ret = jbt_ret_write_0(lcd, JBT_REG_DISPLAY_ON, NULL);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return jbt_ret_write_0(lcd, JBT_REG_DISPLAY_ON, NULL);
> }
>
> static int td028ttec1_disable(struct drm_panel *panel)
> --
> 2.23.0