2020-09-21 17:45:13

by Alex Dewar

Subject: [PATCH] staging: hikey9xx: Fix incorrect assignement

In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its
default value is assigned to priv->eye_diagram_param, rather than
priv->tx_vboost_lvl. Fix this.

Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670")
Addresses-Coverity: CID 1497107: Incorrect expression (COPY_PASTE_ERROR)
Signed-off-by: Alex Dewar <[email protected]>
---
drivers/staging/hikey9xx/phy-hi3670-usb3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
index 42dbc20a0b9a..4fc013911a78 100644
--- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
+++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
@@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev)

if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl",
&priv->tx_vboost_lvl))
- priv->eye_diagram_param = KIRIN970_USB_DEFAULT_PHY_VBOOST;
+ priv->tx_vboost_lvl = KIRIN970_USB_DEFAULT_PHY_VBOOST;

phy = devm_phy_create(dev, NULL, &hi3670_phy_ops);
if (IS_ERR(phy))
--
2.28.0

2020-09-21 21:24:18

by Alex Dewar

Subject: [PATCH v2] staging: hikey9xx: Fix incorrect assignment

In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its
default value is assigned to priv->eye_diagram_param, rather than to
priv->tx_vboost_lvl. Fix this.

Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670")
Addresses-Coverity: CID 1497107: Incorrect expression (COPY_PASTE_ERROR)
Signed-off-by: Alex Dewar <[email protected]>
---
v2: Fix my email address and a typo in title

drivers/staging/hikey9xx/phy-hi3670-usb3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
index 42dbc20a0b9a..4fc013911a78 100644
--- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
+++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
@@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev)

if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl",
&priv->tx_vboost_lvl))
- priv->eye_diagram_param = KIRIN970_USB_DEFAULT_PHY_VBOOST;
+ priv->tx_vboost_lvl = KIRIN970_USB_DEFAULT_PHY_VBOOST;

phy = devm_phy_create(dev, NULL, &hi3670_phy_ops);
if (IS_ERR(phy))
--
2.28.0

2020-09-22 08:35:18

by Mauro Carvalho Chehab

Subject: Re: [PATCH v2] staging: hikey9xx: Fix incorrect assignment

Em Mon, 21 Sep 2020 22:21:47 +0100
Alex Dewar <[email protected]> escreveu:

> In hi3670_phy_probe(), when reading property tx-vboost-lvl fails, its
> default value is assigned to priv->eye_diagram_param, rather than to
> priv->tx_vboost_lvl. Fix this.
>
> Fixes: 8971a3b880b2 ("staging: hikey9xx: add USB physical layer for Kirin 3670")
> Addresses-Coverity: CID 1497107: Incorrect expression (COPY_PASTE_ERROR)
> Signed-off-by: Alex Dewar <[email protected]>

Patch looks good to me. I also double-checked if everything
works ok after this fix - although it should, as the DT I'm using
has "hisilicon,tx-vboost-lvl" property defined. So:

Reviewed-by: Mauro Carvalho Chehab <[email protected]>
Tested-by: Mauro Carvalho Chehab <[email protected]>



> ---
> v2: Fix my email address and a typo in title
>
> drivers/staging/hikey9xx/phy-hi3670-usb3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> index 42dbc20a0b9a..4fc013911a78 100644
> --- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> +++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> @@ -640,7 +640,7 @@ static int hi3670_phy_probe(struct platform_device *pdev)
>
> if (of_property_read_u32(dev->of_node, "hisilicon,tx-vboost-lvl",
> &priv->tx_vboost_lvl))
> - priv->eye_diagram_param = KIRIN970_USB_DEFAULT_PHY_VBOOST;
> + priv->tx_vboost_lvl = KIRIN970_USB_DEFAULT_PHY_VBOOST;
>
> phy = devm_phy_create(dev, NULL, &hi3670_phy_ops);
> if (IS_ERR(phy))



Thanks,
Mauro