2020-09-25 06:28:06

by Jing Xiangfeng

Subject: [PATCH] scsi: bfa: fix error return in bfad_pci_init()

Fix to return error code -ENODEV from the error handling case instead
of 0.

Fixes: 11ea3824140c ("scsi: bfa: fix calls to dma_set_mask_and_coherent()")
Signed-off-by: Jing Xiangfeng <[email protected]>
---
drivers/scsi/bfa/bfad.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c
index bc5d84f87d8f..440ef32be048 100644
--- a/drivers/scsi/bfa/bfad.c
+++ b/drivers/scsi/bfa/bfad.c
@@ -749,6 +749,7 @@ bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad)

if (bfad->pci_bar0_kva == NULL) {
printk(KERN_ERR "Fail to map bar0\n");
+ rc = -ENODEV;
goto out_release_region;
}

--
2.17.1

2020-10-08 03:10:57

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bfa: fix error return in bfad_pci_init()

Jing,

> Fix to return error code -ENODEV from the error handling case instead
> of 0.

Applied to 5.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-10-14 07:14:50

by Martin K. Petersen

Subject: Re: [PATCH] scsi: bfa: fix error return in bfad_pci_init()

On Fri, 25 Sep 2020 14:24:23 +0800, Jing Xiangfeng wrote:

> Fix to return error code -ENODEV from the error handling case instead
> of 0.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: bfa: Fix error return in bfad_pci_init()
https://git.kernel.org/mkp/scsi/c/f0f6c3a4fcb8

--
Martin K. Petersen Oracle Linux Engineering