Hi All,
This patch series enables PCIe, SPI NOR flash, CAN0 and SD2 LED indication
on iWave G21D-Q7 board.
Patches apply on top of [1] and also dependent on patch [2]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/geert/
renesas-devel.git/log/?h=renesas-arm-dt-for-v5.10
[2] https://patchwork.kernel.org/patch/11712541/
Cheers,
Prabhakar
v1->v2
* Set SD2 LED trigger GPIO as GPIO_ACTIVE_HIGH
* Added missing "msiof0_sync" in msiof0 pins
* Corrected to can1 interface on carrier board
Lad Prabhakar (3):
ARM: dts: r8a7742-iwg21d-q7: Add SPI NOR support
ARM: dts: r8a7742-iwg21d-q7: Add can1 support to carrier board
ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication
arch/arm/boot/dts/r8a7742-iwg21d-q7.dts | 62 +++++++++++++++++++++++++
1 file changed, 62 insertions(+)
--
2.17.1
This patch enables CAN1 interface exposed through connector J20 on the
carrier board.
Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Chris Paterson <[email protected]>
---
arch/arm/boot/dts/r8a7742-iwg21d-q7.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
index 818f1a850c62..66881a473d6c 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
@@ -198,6 +198,13 @@
};
};
+&can1 {
+ pinctrl-0 = <&can1_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+};
+
&cmt0 {
status = "okay";
};
@@ -214,6 +221,15 @@
};
};
+&gpio1 {
+ can-trx-en-gpio{
+ gpio-hog;
+ gpios = <28 GPIO_ACTIVE_HIGH>;
+ output-low;
+ line-name = "can-trx-en-gpio";
+ };
+};
+
&hsusb {
pinctrl-0 = <&usb0_pins>;
pinctrl-names = "default";
@@ -287,6 +303,11 @@
function = "tpu0";
};
+ can1_pins: can1 {
+ groups = "can1_data_b";
+ function = "can1";
+ };
+
i2c2_pins: i2c2 {
groups = "i2c2_b";
function = "i2c2";
--
2.17.1
Add support for LED trigger on SD2 interface.
Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Chris Paterson <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
---
arch/arm/boot/dts/r8a7742-iwg21d-q7.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
index 66881a473d6c..e45b502d61cb 100644
--- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
@@ -63,6 +63,16 @@
enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>;
};
+ leds {
+ compatible = "gpio-leds";
+
+ sdhi2_led {
+ label = "sdio-led";
+ gpios = <&gpio5 22 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "mmc1";
+ };
+ };
+
lvds-receiver {
compatible = "ti,ds90cf384a", "lvds-decoder";
vcc-supply = <&vcc_3v3_tft1>;
--
2.17.1
On Mon, Sep 7, 2020 at 5:56 PM Lad Prabhakar
<[email protected]> wrote:
> This patch enables CAN1 interface exposed through connector J20 on the
> carrier board.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
Thanks for the update, will queue in renesas-devel for v5.10.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Mon, Sep 7, 2020 at 5:56 PM Lad Prabhakar
<[email protected]> wrote:
> Add support for LED trigger on SD2 interface.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Chris Paterson <[email protected]>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
Thanks for the update, will queue in renesas-devel for v5.10.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi!
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
> @@ -63,6 +63,16 @@
> enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>;
> };
>
> + leds {
> + compatible = "gpio-leds";
> +
> + sdhi2_led {
> + label = "sdio-led";
This should use appropriate label... probably mmc1:green:activity.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi Pavel,
Thank you for the review.
On Fri, Oct 9, 2020 at 8:33 AM Pavel Machek <[email protected]> wrote:
>
> Hi!
>
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
> > @@ -63,6 +63,16 @@
> > enable-gpios = <&gpio3 11 GPIO_ACTIVE_HIGH>;
> > };
> >
> > + leds {
> > + compatible = "gpio-leds";
> > +
> > + sdhi2_led {
> > + label = "sdio-led";
>
> This should use appropriate label... probably mmc1:green:activity.
>
$ grep -nr mmc | grep -i activity
$ grep -nr sd | grep -i activity
Results in 0 outputs in dts folder.
Cheers,
Prabhakar
Hi!
> Thank you for the review.
Note I'm LED maintainer.
> > > + leds {
> > > + compatible = "gpio-leds";
> > > +
> > > + sdhi2_led {
> > > + label = "sdio-led";
> >
> > This should use appropriate label... probably mmc1:green:activity.
> >
> $ grep -nr mmc | grep -i activity
> $ grep -nr sd | grep -i activity
>
> Results in 0 outputs in dts folder.
Well, so does
grep -ri label.*sdio-led arch/arm*
:-). Feel free to suggest other name following documentation in
Documentation/leds/leds-class.rst .
(And yes, we have lot of work to get this to some kind of consistent
state).
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany