2020-10-28 06:00:30

by Felipe Balbi

Subject: [PATCH 2/2] irqchip: bcm2836: fix section mismatch warning

From: Felipe Balbi <[email protected]>

Fix the following warning:

WARNING: modpost: vmlinux.o(.text.unlikely+0x17b2c): Section mismatch in reference from the function bcm2836_arm_irqchip_smp_init() to the function .init.text:set_smp_ipi_range()
The function bcm2836_arm_irqchip_smp_init() references
the function __init set_smp_ipi_range().
This is often because bcm2836_arm_irqchip_smp_init lacks a __init
annotation or the annotation of set_smp_ipi_range is wrong.

Signed-off-by: Felipe Balbi <[email protected]>
---
drivers/irqchip/irq-bcm2836.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c
index 97838eb705f9..cbc7c740e4dc 100644
--- a/drivers/irqchip/irq-bcm2836.c
+++ b/drivers/irqchip/irq-bcm2836.c
@@ -244,7 +244,7 @@ static int bcm2836_cpu_dying(unsigned int cpu)

#define BITS_PER_MBOX 32

-static void bcm2836_arm_irqchip_smp_init(void)
+static void __init bcm2836_arm_irqchip_smp_init(void)
{
struct irq_fwspec ipi_fwspec = {
.fwnode = intc.domain->fwnode,
--
2.29.1

2020-10-28 06:04:17

by Marc Zyngier

Subject: Re: [PATCH 2/2] irqchip: bcm2836: fix section mismatch warning

On 2020-10-27 08:51, [email protected] wrote:
> From: Felipe Balbi <[email protected]>
>
> Fix the following warning:
>
> WARNING: modpost: vmlinux.o(.text.unlikely+0x17b2c): Section mismatch
> in reference from the function bcm2836_arm_irqchip_smp_init() to the
> function .init.text:set_smp_ipi_range()
> The function bcm2836_arm_irqchip_smp_init() references
> the function __init set_smp_ipi_range().
> This is often because bcm2836_arm_irqchip_smp_init lacks a __init
> annotation or the annotation of set_smp_ipi_range is wrong.
>
> Signed-off-by: Felipe Balbi <[email protected]>
> ---
> drivers/irqchip/irq-bcm2836.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-bcm2836.c
> b/drivers/irqchip/irq-bcm2836.c
> index 97838eb705f9..cbc7c740e4dc 100644
> --- a/drivers/irqchip/irq-bcm2836.c
> +++ b/drivers/irqchip/irq-bcm2836.c
> @@ -244,7 +244,7 @@ static int bcm2836_cpu_dying(unsigned int cpu)
>
> #define BITS_PER_MBOX 32
>
> -static void bcm2836_arm_irqchip_smp_init(void)
> +static void __init bcm2836_arm_irqchip_smp_init(void)
> {
> struct irq_fwspec ipi_fwspec = {
> .fwnode = intc.domain->fwnode,

I already have a fix for this one[1], which should be in -next.

Thanks,

M.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=57733e009f0c7e0526e10a18be12f56996c5460e
--
Jazz is not dead. It just smells funny...