2020-10-29 08:45:07

by Qinglang Miao

Subject: [PATCH] mips: cm: add missing iounmap() on error in mips_cm_probe()

Add the missing iounmap() of iounmap(mips_gcr_base) before
return from mips_cm_probe() in the error handling case.

Signed-off-by: Qinglang Miao <[email protected]>
---
arch/mips/kernel/mips-cm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c
index f60af512c..90f1c3df1 100644
--- a/arch/mips/kernel/mips-cm.c
+++ b/arch/mips/kernel/mips-cm.c
@@ -266,6 +266,7 @@ int mips_cm_probe(void)
if ((base_reg & CM_GCR_BASE_GCRBASE) != addr) {
pr_err("GCRs appear to have been moved (expected them at 0x%08lx)!\n",
(unsigned long)addr);
+ iounmap(mips_gcr_base);
mips_gcr_base = NULL;
return -ENODEV;
}
--
2.23.0

2020-11-06 10:56:15

by Thomas Bogendoerfer

Subject: Re: [PATCH] mips: cm: add missing iounmap() on error in mips_cm_probe()

On Wed, Oct 28, 2020 at 05:15:46PM +0800, Qinglang Miao wrote:
> Add the missing iounmap() of iounmap(mips_gcr_base) before
> return from mips_cm_probe() in the error handling case.
>
> Signed-off-by: Qinglang Miao <[email protected]>
> ---
> arch/mips/kernel/mips-cm.c | 1 +
> 1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]