2020-10-29 09:09:59

by Xu Wang

Subject: [PATCH] ASoC: samsung: i2s: Remove redundant null check before clk_disable_unprepare

Because clk_disable_unprepare() already checked NULL clock parameter,
so the additional check is unnecessary, just remove it.

Signed-off-by: Xu Wang <[email protected]>
---
sound/soc/samsung/i2s.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index df53d4ea808f..36969f0a3f9a 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -1212,8 +1212,7 @@ static int i2s_runtime_suspend(struct device *dev)
priv->suspend_i2scon = readl(priv->addr + I2SCON);
priv->suspend_i2spsr = readl(priv->addr + I2SPSR);

- if (priv->op_clk)
- clk_disable_unprepare(priv->op_clk);
+ clk_disable_unprepare(priv->op_clk);
clk_disable_unprepare(priv->clk);

return 0;
--
2.17.1

2020-10-29 18:40:07

by Krzysztof Kozlowski

Subject: Re: [PATCH] ASoC: samsung: i2s: Remove redundant null check before clk_disable_unprepare

On Thu, Oct 29, 2020 at 08:37:15AM +0000, Xu Wang wrote:
> Because clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove it.

You missed other places with it - the resume part.

Best regards,
Krzysztof

>
> Signed-off-by: Xu Wang <[email protected]>
> ---
> sound/soc/samsung/i2s.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)