2020-09-25 13:26:50

by Ioana Ciornei

Subject: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs

Annotate the EMDIO1 node and describe the 4 10GBASER PHYs found on the
LS2088ARDB board. Also, add phy-handles for DPMACs 1-4 to their
associated PHY.

Signed-off-by: Ioana Ciornei <[email protected]>
---
.../boot/dts/freescale/fsl-ls2088a-rdb.dts | 41 +++++++++++++++++++
1 file changed, 41 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
index f6b4d75a258b..0d1935fcd201 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
@@ -22,3 +22,44 @@ chosen {
stdout-path = "serial1:115200n8";
};
};
+
+&dpmac1 {
+ phy-handle = <&mdio1_phy1>;
+};
+
+&dpmac2 {
+ phy-handle = <&mdio1_phy2>;
+};
+
+&dpmac3 {
+ phy-handle = <&mdio1_phy3>;
+};
+
+&dpmac4 {
+ phy-handle = <&mdio1_phy4>;
+};
+
+&emdio1 {
+ status = "okay";
+
+ mdio1_phy1: emdio1_phy@1 {
+ compatible = "ethernet-phy-id13e5.1002";
+ reg = <0x10>;
+ phy-connection-type = "10gbase-r";
+ };
+ mdio1_phy2: emdio1_phy@2 {
+ compatible = "ethernet-phy-id13e5.1002";
+ reg = <0x11>;
+ phy-connection-type = "10gbase-r";
+ };
+ mdio1_phy3: emdio1_phy@3 {
+ compatible = "ethernet-phy-id13e5.1002";
+ reg = <0x12>;
+ phy-connection-type = "10gbase-r";
+ };
+ mdio1_phy4: emdio1_phy@4 {
+ compatible = "ethernet-phy-id13e5.1002";
+ reg = <0x13>;
+ phy-connection-type = "10gbase-r";
+ };
+};
--
2.25.1

2020-10-30 00:14:51

by Shawn Guo

Subject: Re: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs

On Fri, Sep 25, 2020 at 04:24:59PM +0300, Ioana Ciornei wrote:
> Annotate the EMDIO1 node and describe the 4 10GBASER PHYs found on the
> LS2088ARDB board. Also, add phy-handles for DPMACs 1-4 to their
> associated PHY.
>
> Signed-off-by: Ioana Ciornei <[email protected]>
> ---
> .../boot/dts/freescale/fsl-ls2088a-rdb.dts | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> index f6b4d75a258b..0d1935fcd201 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> @@ -22,3 +22,44 @@ chosen {
> stdout-path = "serial1:115200n8";
> };
> };
> +
> +&dpmac1 {
> + phy-handle = <&mdio1_phy1>;
> +};
> +
> +&dpmac2 {
> + phy-handle = <&mdio1_phy2>;
> +};
> +
> +&dpmac3 {
> + phy-handle = <&mdio1_phy3>;
> +};
> +
> +&dpmac4 {
> + phy-handle = <&mdio1_phy4>;
> +};
> +
> +&emdio1 {
> + status = "okay";
> +
> + mdio1_phy1: emdio1_phy@1 {
> + compatible = "ethernet-phy-id13e5.1002";
> + reg = <0x10>;
> + phy-connection-type = "10gbase-r";
> + };

Please have a newline between nodes.

Shawn

> + mdio1_phy2: emdio1_phy@2 {
> + compatible = "ethernet-phy-id13e5.1002";
> + reg = <0x11>;
> + phy-connection-type = "10gbase-r";
> + };
> + mdio1_phy3: emdio1_phy@3 {
> + compatible = "ethernet-phy-id13e5.1002";
> + reg = <0x12>;
> + phy-connection-type = "10gbase-r";
> + };
> + mdio1_phy4: emdio1_phy@4 {
> + compatible = "ethernet-phy-id13e5.1002";
> + reg = <0x13>;
> + phy-connection-type = "10gbase-r";
> + };
> +};
> --
> 2.25.1
>

2020-10-30 09:42:13

by Ioana Ciornei

Subject: Re: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs

On Fri, Oct 30, 2020 at 08:10:38AM +0800, Shawn Guo wrote:
> On Fri, Sep 25, 2020 at 04:24:59PM +0300, Ioana Ciornei wrote:
> > Annotate the EMDIO1 node and describe the 4 10GBASER PHYs found on the
> > LS2088ARDB board. Also, add phy-handles for DPMACs 1-4 to their
> > associated PHY.
> >
> > Signed-off-by: Ioana Ciornei <[email protected]>
> > ---
> > .../boot/dts/freescale/fsl-ls2088a-rdb.dts | 41 +++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> > index f6b4d75a258b..0d1935fcd201 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts
> > @@ -22,3 +22,44 @@ chosen {
> > stdout-path = "serial1:115200n8";
> > };
> > };
> > +
> > +&dpmac1 {
> > + phy-handle = <&mdio1_phy1>;
> > +};
> > +
> > +&dpmac2 {
> > + phy-handle = <&mdio1_phy2>;
> > +};
> > +
> > +&dpmac3 {
> > + phy-handle = <&mdio1_phy3>;
> > +};
> > +
> > +&dpmac4 {
> > + phy-handle = <&mdio1_phy4>;
> > +};
> > +
> > +&emdio1 {
> > + status = "okay";
> > +
> > + mdio1_phy1: emdio1_phy@1 {
> > + compatible = "ethernet-phy-id13e5.1002";
> > + reg = <0x10>;
> > + phy-connection-type = "10gbase-r";
> > + };
>
> Please have a newline between nodes.
>

Sure.