2020-11-03 12:48:59

by Łukasz Stelmach

[permalink] [raw]
Subject: [PATCH 0/5] Add Ethernet interface description for Odroid boards

Add devicetree description of Ethernet devices on Odroid boards. These
descriptions enable setting MAC addresses with a bootloader.

Łukasz Stelmach (5):
ARM: dts: exynos: Fix ethernet description for Odroid XU3
ARM: dts: exynos: Add Ethernet interface description for Odroid X3
Lite
ARM: dts: exynos: Add Ethernet interface description for Odroid XU
ARM: dts: exynos: Add Ethernet interface description for Odroid U3
ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

arch/arm/boot/dts/exynos4412-odroidu3.dts | 12 ++++++++
arch/arm/boot/dts/exynos4412-odroidx.dts | 28 +++++++++++++++++++
arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 ++++++++++
.../boot/dts/exynos5422-odroidxu3-lite.dts | 22 +++++++++++++++
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 8 ++++--
5 files changed, 83 insertions(+), 2 deletions(-)

--
2.26.2


2020-11-03 12:50:05

by Łukasz Stelmach

[permalink] [raw]
Subject: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

Add Ethernet interface description for Odroid X/X2.

Signed-off-by: Łukasz Stelmach <[email protected]>
---
arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 3ea2a0101e80..8f154f431f6c 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -15,6 +15,10 @@ / {
model = "Hardkernel ODROID-X board based on Exynos4412";
compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";

+ aliases {
+ ethernet = &ethernet;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x3FF00000>;
@@ -72,8 +76,32 @@ &buck8_reg {
};

&ehci {
+ #address-cells = <1>;
+ #size-cells = <0>;
phys = <&exynos_usbphy 2>;
phy-names = "hsic0";
+
+ hub@2 {
+ compatible = "usb0424,3503";
+ reg = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub@1 {
+ compatible = "usb0424:9514";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet: usbether@1 {
+ compatible = "usb0424,ec00";
+ reg = <1>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+ };
+ };
+ };
+
+
};

&mshc_0 {
--
2.26.2

2020-11-03 12:51:29

by Łukasz Stelmach

[permalink] [raw]
Subject: [PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU

Add Ethernet interface description for Odroid XU.

Signed-off-by: Łukasz Stelmach <[email protected]>
---
arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 75b4150c26d7..882d9296fa5d 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -19,6 +19,10 @@ / {
model = "Hardkernel Odroid XU";
compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";

+ aliases {
+ ethernet = &ethernet;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0x40000000 0x7ea00000>;
@@ -653,3 +657,14 @@ &usbdrd3_1 {
vdd33-supply = <&ldo12_reg>;
vdd10-supply = <&ldo15_reg>;
};
+
+&usbhost2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet: usbether@2 {
+ compatible = "usb0424,9730";
+ reg = <2>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
+ };
+};
--
2.26.2

2020-11-03 16:42:02

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 3/5] ARM: dts: exynos: Add Ethernet interface description for Odroid XU

On Tue, Nov 03, 2020 at 01:46:16PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid XU.
>
> Signed-off-by: Łukasz Stelmach <[email protected]>
> ---
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index 75b4150c26d7..882d9296fa5d 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -19,6 +19,10 @@ / {
> model = "Hardkernel Odroid XU";
> compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
>
> + aliases {
> + ethernet = &ethernet;

Just like with patch 1/5 - please explain in commit msg why do you need
this.

Best regards,
Krzysztof

2020-11-03 16:46:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> Add Ethernet interface description for Odroid X/X2.
>
> Signed-off-by: Łukasz Stelmach <[email protected]>
> ---
> arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> index 3ea2a0101e80..8f154f431f6c 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> @@ -15,6 +15,10 @@ / {
> model = "Hardkernel ODROID-X board based on Exynos4412";
> compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>
> + aliases {
> + ethernet = &ethernet;
> + };
> +
> memory@40000000 {
> device_type = "memory";
> reg = <0x40000000 0x3FF00000>;
> @@ -72,8 +76,32 @@ &buck8_reg {
> };
>
> &ehci {
> + #address-cells = <1>;
> + #size-cells = <0>;
> phys = <&exynos_usbphy 2>;
> phy-names = "hsic0";
> +
> + hub@2 {
> + compatible = "usb0424,3503";
> + reg = <2>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hub@1 {
> + compatible = "usb0424:9514";

Does not look like correct compatible.

Best regards,
Krzysztof

2020-11-03 17:15:33

by Łukasz Stelmach

[permalink] [raw]
Subject: Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
>> Add Ethernet interface description for Odroid X/X2.
>>
>> Signed-off-by: Łukasz Stelmach <[email protected]>
>> ---
>> arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> index 3ea2a0101e80..8f154f431f6c 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
>> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> @@ -15,6 +15,10 @@ / {
>> model = "Hardkernel ODROID-X board based on Exynos4412";
>> compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
>>
>> + aliases {
>> + ethernet = &ethernet;
>> + };
>> +
>> memory@40000000 {
>> device_type = "memory";
>> reg = <0x40000000 0x3FF00000>;
>> @@ -72,8 +76,32 @@ &buck8_reg {
>> };
>>
>> &ehci {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> phys = <&exynos_usbphy 2>;
>> phy-names = "hsic0";
>> +
>> + hub@2 {
>> + compatible = "usb0424,3503";
>> + reg = <2>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + hub@1 {
>> + compatible = "usb0424:9514";
>
> Does not look like correct compatible.

As odd as it may seem (and considering my mistakes) this is correct.

--8<---------------cut here---------------start------------->8---
root@target:~# cat /proc/device-tree/compatible ; echo
hardkernel,odroid-x2samsung,exynos4412samsung,exynos4
root@target:~# lsusb -t
/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=exynos-ehci/3p, 480M
|__ Port 2: Dev 2, If 0, Class=Hub, Driver=hub/3p, 480M
|__ Port 1: Dev 3, If 0, Class=Hub, Driver=hub/5p, 480M
|__ Port 1: Dev 4, If 0, Class=Vendor Specific Class, Driver=smsc95xx, 480M
root@target:~# lsusb
Bus 001 Device 004: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter
Bus 001 Device 003: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub
Bus 001 Device 002: ID 0424:3503 Standard Microsystems Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
--8<---------------cut here---------------end--------------->8---

--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Attachments:
signature.asc (497.00 B)

2020-11-03 17:24:36

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 5/5] ARM: dts: exynos: Add Ethernet interface description for Odroid X/X2

On Tue, 3 Nov 2020 at 18:13, Lukasz Stelmach <[email protected]> wrote:
>
> It was <2020-11-03 wto 17:44>, when Krzysztof Kozlowski wrote:
> > On Tue, Nov 03, 2020 at 01:46:18PM +0100, Łukasz Stelmach wrote:
> >> Add Ethernet interface description for Odroid X/X2.
> >>
> >> Signed-off-by: Łukasz Stelmach <[email protected]>
> >> ---
> >> arch/arm/boot/dts/exynos4412-odroidx.dts | 28 ++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> index 3ea2a0101e80..8f154f431f6c 100644
> >> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> >> @@ -15,6 +15,10 @@ / {
> >> model = "Hardkernel ODROID-X board based on Exynos4412";
> >> compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
> >>
> >> + aliases {
> >> + ethernet = &ethernet;
> >> + };
> >> +
> >> memory@40000000 {
> >> device_type = "memory";
> >> reg = <0x40000000 0x3FF00000>;
> >> @@ -72,8 +76,32 @@ &buck8_reg {
> >> };
> >>
> >> &ehci {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> phys = <&exynos_usbphy 2>;
> >> phy-names = "hsic0";
> >> +
> >> + hub@2 {
> >> + compatible = "usb0424,3503";
> >> + reg = <2>;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + hub@1 {
> >> + compatible = "usb0424:9514";
> >
> > Does not look like correct compatible.
>
> As odd as it may seem (and considering my mistakes) this is correct.

Not the numbers, the format. Comma is needed.

Best regards,
Krzysztof