2020-11-09 01:22:23

by Jisheng Zhang

Subject: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg

The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
needed, because the phy core will call genphy_config_aneg() if the
.config_aneg is NULL.

Signed-off-by: Jisheng Zhang <[email protected]>
---
drivers/net/phy/microchip_t1.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
index fed3e395f18e..1c9900162619 100644
--- a/drivers/net/phy/microchip_t1.c
+++ b/drivers/net/phy/microchip_t1.c
@@ -219,7 +219,6 @@ static struct phy_driver microchip_t1_phy_driver[] = {
.features = PHY_BASIC_T1_FEATURES,

.config_init = lan87xx_config_init,
- .config_aneg = genphy_config_aneg,

.ack_interrupt = lan87xx_phy_ack_interrupt,
.config_intr = lan87xx_phy_config_intr,
--
2.29.2

2020-11-09 17:40:39

by Andrew Lunn

Subject: Re: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg

On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote:
> The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
> needed, because the phy core will call genphy_config_aneg() if the
> .config_aneg is NULL.
>
> Signed-off-by: Jisheng Zhang <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2020-11-10 01:43:42

by Jakub Kicinski

Subject: Re: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg

On Mon, 9 Nov 2020 18:36:22 +0100 Andrew Lunn wrote:
> On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote:
> > The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
> > needed, because the phy core will call genphy_config_aneg() if the
> > .config_aneg is NULL.
> >
> > Signed-off-by: Jisheng Zhang <[email protected]>
>
> Reviewed-by: Andrew Lunn <[email protected]>

Applied, thanks!