2020-11-10 13:43:18

by Qi Zheng

Subject: [PATCH] sched/fair: Remove the redundant critical section

Now there is nothing in the critical section, so remove it.

Signed-off-by: Qi Zheng <[email protected]>
---
kernel/sched/fair.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 52cacfc62922..06c4f3430e95 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5114,9 +5114,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
return;

distribute_cfs_runtime(cfs_b);
-
- raw_spin_lock_irqsave(&cfs_b->lock, flags);
- raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
}

/*
--
2.25.1

2020-11-10 13:51:33

by Vincent Guittot

Subject: Re: [PATCH] sched/fair: Remove the redundant critical section

On Tue, 10 Nov 2020 at 14:41, Qi Zheng <[email protected]> wrote:
>
> Now there is nothing in the critical section, so remove it.

https://lkml.org/lkml/2020/10/30/689

>
> Signed-off-by: Qi Zheng <[email protected]>
> ---
> kernel/sched/fair.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 52cacfc62922..06c4f3430e95 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5114,9 +5114,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
> return;
>
> distribute_cfs_runtime(cfs_b);
> -
> - raw_spin_lock_irqsave(&cfs_b->lock, flags);
> - raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
> }
>
> /*
> --
> 2.25.1
>