2020-11-12 11:37:31

by Zhang Changzhong

Subject: [PATCH net] net: ethernet: mtk-star-emac: fix error return code in mtk_star_enable()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhang Changzhong <[email protected]>
---
drivers/net/ethernet/mediatek/mtk_star_emac.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
index 1325055..2ebacb6 100644
--- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
+++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
@@ -966,6 +966,7 @@ static int mtk_star_enable(struct net_device *ndev)
mtk_star_adjust_link, 0, priv->phy_intf);
if (!priv->phydev) {
netdev_err(ndev, "failed to connect to PHY\n");
+ ret = -ENODEV;
goto err_free_irq;
}

--
2.9.5

2020-11-12 11:53:16

by Bartosz Golaszewski

Subject: Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code in mtk_star_enable()

On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong
<[email protected]> wrote:
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhang Changzhong <[email protected]>
> ---
> drivers/net/ethernet/mediatek/mtk_star_emac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index 1325055..2ebacb6 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -966,6 +966,7 @@ static int mtk_star_enable(struct net_device *ndev)
> mtk_star_adjust_link, 0, priv->phy_intf);
> if (!priv->phydev) {
> netdev_err(ndev, "failed to connect to PHY\n");
> + ret = -ENODEV;
> goto err_free_irq;
> }
>
> --
> 2.9.5
>

Acked-by: Bartosz Golaszewski <[email protected]>

2020-11-13 02:02:45

by Jakub Kicinski

Subject: Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code in mtk_star_enable()

On Thu, 12 Nov 2020 12:41:26 +0100 Bartosz Golaszewski wrote:
> On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong
> <[email protected]> wrote:
> >
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: Zhang Changzhong <[email protected]>
>
> Acked-by: Bartosz Golaszewski <[email protected]>

Applied, thanks!