2020-11-11 02:53:26

by Nick Desaulniers

Subject: [PATCH] ARM: unwind: remove old check for GCC <= 4.2

Since
commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
the minimum supported version of GCC is gcc-4.9. It's now safe to remove
this code.

Link: https://github.com/ClangBuiltLinux/linux/issues/427
Signed-off-by: Nick Desaulniers <[email protected]>
---
arch/arm/kernel/unwind.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
index f35eb584a18a..59fdf257bf8b 100644
--- a/arch/arm/kernel/unwind.c
+++ b/arch/arm/kernel/unwind.c
@@ -18,9 +18,6 @@
#warning Your compiler does not have EABI support.
#warning ARM unwind is known to compile only with EABI compilers.
#warning Change compiler or disable ARM_UNWIND option.
-#elif (__GNUC__ == 4 && __GNUC_MINOR__ <= 2) && !defined(__clang__)
-#warning Your compiler is too buggy; it is known to not compile ARM unwind support.
-#warning Change compiler or disable ARM_UNWIND option.
#endif
#endif /* __CHECKER__ */

--
2.29.2.222.g5d2a92d10f8-goog

2020-11-12 18:04:38

by Nathan Chancellor

Subject: Re: [PATCH] ARM: unwind: remove old check for GCC <= 4.2

On Tue, Nov 10, 2020 at 06:51:20PM -0800, 'Nick Desaulniers' via Clang Built Linux wrote:
> Since
> commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
> the minimum supported version of GCC is gcc-4.9. It's now safe to remove
> this code.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/427
> Signed-off-by: Nick Desaulniers <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> arch/arm/kernel/unwind.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
> index f35eb584a18a..59fdf257bf8b 100644
> --- a/arch/arm/kernel/unwind.c
> +++ b/arch/arm/kernel/unwind.c
> @@ -18,9 +18,6 @@
> #warning Your compiler does not have EABI support.
> #warning ARM unwind is known to compile only with EABI compilers.
> #warning Change compiler or disable ARM_UNWIND option.
> -#elif (__GNUC__ == 4 && __GNUC_MINOR__ <= 2) && !defined(__clang__)
> -#warning Your compiler is too buggy; it is known to not compile ARM unwind support.
> -#warning Change compiler or disable ARM_UNWIND option.
> #endif
> #endif /* __CHECKER__ */
>
> --
> 2.29.2.222.g5d2a92d10f8-goog
>