2020-11-04 16:45:23

by Necip Fazil Yildiran

Subject: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB

When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
Selected by [y]:
- BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]

The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
bug report.

Honor the kconfig dependency to remove unmet direct dependency warnings
and avoid any potential build failures.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051
Signed-off-by: Necip Fazil Yildiran <[email protected]>
---
arch/mips/bcm47xx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
index 6889f74e06f5..40876654423c 100644
--- a/arch/mips/bcm47xx/Kconfig
+++ b/arch/mips/bcm47xx/Kconfig
@@ -9,6 +9,7 @@ config BCM47XX_SSB
select SSB_DRIVER_MIPS
select SSB_DRIVER_EXTIF
select SSB_EMBEDDED
+ select SSB_PCIHOST if PCI
select SSB_B43_PCI_BRIDGE if PCI
select SSB_DRIVER_PCICORE if PCI
select SSB_PCICORE_HOSTMODE if PCI
--
2.25.1

2020-11-06 08:26:51

by Sergei Shtylyov

Subject: Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB

Hello!

On 04.11.2020 19:41, Necip Fazil Yildiran wrote:

> When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
> Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
> Selected by [y]:
> - BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]
>
> The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
> depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
> SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
> bug report.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051

Isn't that tag supposed to be used for the patch mail itself? At least
that's what I'm seeing in the USB patches where it points to the msg with
a patch...

> Signed-off-by: Necip Fazil Yildiran <[email protected]>
[...]

MBR, Sergei

2020-11-12 22:53:08

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB

On Wed, Nov 04, 2020 at 07:41:27PM +0300, Necip Fazil Yildiran wrote:
> When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE
> Depends on [n]: SSB [=y] && SSB_PCIHOST [=n]
> Selected by [y]:
> - BCM47XX_SSB [=y] && BCM47XX [=y] && PCI [=y]
>
> The reason is that BCM47XX_SSB selects SSB_B43_PCI_BRIDGE without
> depending on or selecting SSB_PCIHOST while SSB_B43_PCI_BRIDGE depends on
> SSB_PCIHOST. This can also fail building the kernel as demonstrated in a
> bug report.
>
> Honor the kconfig dependency to remove unmet direct dependency warnings
> and avoid any potential build failures.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=210051
> Signed-off-by: Necip Fazil Yildiran <[email protected]>
> ---
> arch/mips/bcm47xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]