2020-11-13 10:11:10

by Dan Carpenter

Subject: [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo_init()

This needs to call of_node_put(np) before returning if of_iomap() fails.

Fixes: e0218dca5787 ("soc: aspeed: Add soc info driver")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/soc/aspeed/aspeed-socinfo.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/aspeed/aspeed-socinfo.c b/drivers/soc/aspeed/aspeed-socinfo.c
index 20a1d4aeb051..773930e0cb10 100644
--- a/drivers/soc/aspeed/aspeed-socinfo.c
+++ b/drivers/soc/aspeed/aspeed-socinfo.c
@@ -74,8 +74,10 @@ static int __init aspeed_socinfo_init(void)
}

reg = of_iomap(np, 0);
- if (!reg)
+ if (!reg) {
+ of_node_put(np);
return -ENODEV;
+ }
siliconid = readl(reg);
iounmap(reg);

--
2.28.0

2020-11-16 04:22:41

by Andrew Jeffery

Subject: Re: [PATCH] soc: aspeed: Fix a reference leak in aspeed_socinfo_init()

On Fri, 13 Nov 2020, at 20:38, Dan Carpenter wrote:
> This needs to call of_node_put(np) before returning if of_iomap() fails.
>
> Fixes: e0218dca5787 ("soc: aspeed: Add soc info driver")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Andrew Jeffery <[email protected]>