2020-11-17 18:03:19

by Filip Moc

Subject: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400

LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.

Signed-off-by: Filip Moc <[email protected]>
---
drivers/net/usb/qmi_wwan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index afeb09b9624e..d166c321ee9b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
- {QMI_FIXED_INTF(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
+ {QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},
--
2.28.0

2020-11-17 19:38:47

by Bjørn Mork

Subject: Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400

Filip Moc <[email protected]> writes:

> LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.
>
> Signed-off-by: Filip Moc <[email protected]>
> ---
> drivers/net/usb/qmi_wwan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index afeb09b9624e..d166c321ee9b 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
> {QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
> {QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
> - {QMI_FIXED_INTF(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
> + {QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
> {QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
> {QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
> {QMI_FIXED_INTF(0x05c6, 0x9031, 5)},

Acked-by: Bjørn Mork <[email protected]>

This fix should probably go to net+stable.


Thanks,
Bjørn

2020-11-18 18:54:02

by Jakub Kicinski

Subject: Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400

On Tue, 17 Nov 2020 20:22:03 +0100 Bjørn Mork wrote:
> Filip Moc <[email protected]> writes:
>
> > LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.
> >
> > Signed-off-by: Filip Moc <[email protected]>
> > ---
> > drivers/net/usb/qmi_wwan.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index afeb09b9624e..d166c321ee9b 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
> > {QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
> > {QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
> > {QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
> > - {QMI_FIXED_INTF(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
> > + {QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
> > {QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
> > {QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
> > {QMI_FIXED_INTF(0x05c6, 0x9031, 5)},
>
> Acked-by: Bjørn Mork <[email protected]>
>
> This fix should probably go to net+stable.

Done, thanks!