2020-11-19 07:27:38

by Dmitry Torokhov

Subject: [PATCH] Input: adp5589-keys - mark suspend and resume methods as __maybe_unused

This improves compile coverage of the code; unused code will be dropped by
the linker.

Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/input/keyboard/adp5589-keys.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c
index 31145a85c819..a9b69a268c09 100644
--- a/drivers/input/keyboard/adp5589-keys.c
+++ b/drivers/input/keyboard/adp5589-keys.c
@@ -1016,8 +1016,7 @@ static int adp5589_probe(struct i2c_client *client,
return 0;
}

-#ifdef CONFIG_PM_SLEEP
-static int adp5589_suspend(struct device *dev)
+static int __maybe_unused adp5589_suspend(struct device *dev)
{
struct adp5589_kpad *kpad = dev_get_drvdata(dev);
struct i2c_client *client = kpad->client;
@@ -1033,7 +1032,7 @@ static int adp5589_suspend(struct device *dev)
return 0;
}

-static int adp5589_resume(struct device *dev)
+static int __maybe_unused adp5589_resume(struct device *dev)
{
struct adp5589_kpad *kpad = dev_get_drvdata(dev);
struct i2c_client *client = kpad->client;
@@ -1048,7 +1047,6 @@ static int adp5589_resume(struct device *dev)

return 0;
}
-#endif

static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend, adp5589_resume);

--
2.29.2.299.gdc1121823c-goog


--
Dmitry

2020-11-19 08:10:47

by Alexandru Ardelean

Subject: RE: [PATCH] Input: adp5589-keys - mark suspend and resume methods as __maybe_unused

> -----Original Message-----
> From: Dmitry Torokhov <[email protected]>
> Sent: Thursday, November 19, 2020 9:24 AM
> To: [email protected]
> Cc: Ardelean, Alexandru <[email protected]>; linux-
> [email protected]
> Subject: [PATCH] Input: adp5589-keys - mark suspend and resume methods as
> __maybe_unused
>
> [External]
>
> This improves compile coverage of the code; unused code will be dropped by the
> linker.
>

Acked-by: Alexandru Ardelean <[email protected]>

> Signed-off-by: Dmitry Torokhov <[email protected]>
> ---
> drivers/input/keyboard/adp5589-keys.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/adp5589-keys.c
> b/drivers/input/keyboard/adp5589-keys.c
> index 31145a85c819..a9b69a268c09 100644
> --- a/drivers/input/keyboard/adp5589-keys.c
> +++ b/drivers/input/keyboard/adp5589-keys.c
> @@ -1016,8 +1016,7 @@ static int adp5589_probe(struct i2c_client *client,
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> -static int adp5589_suspend(struct device *dev)
> +static int __maybe_unused adp5589_suspend(struct device *dev)
> {
> struct adp5589_kpad *kpad = dev_get_drvdata(dev);
> struct i2c_client *client = kpad->client; @@ -1033,7 +1032,7 @@ static
> int adp5589_suspend(struct device *dev)
> return 0;
> }
>
> -static int adp5589_resume(struct device *dev)
> +static int __maybe_unused adp5589_resume(struct device *dev)
> {
> struct adp5589_kpad *kpad = dev_get_drvdata(dev);
> struct i2c_client *client = kpad->client; @@ -1048,7 +1047,6 @@ static
> int adp5589_resume(struct device *dev)
>
> return 0;
> }
> -#endif
>
> static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend,
> adp5589_resume);
>
> --
> 2.29.2.299.gdc1121823c-goog
>
>
> --
> Dmitry