2020-11-19 14:14:45

by Alexandru Ardelean

Subject: [PATCH] iio: accel: adis16209: remove unneeded spi_set_drvdata()

There is no matching spi_get_drvdata() in the driver. This looks like a
left-over from before the driver was converted to device-managed functions.

Signed-off-by: Alexandru Ardelean <[email protected]>
---
drivers/iio/accel/adis16209.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iio/accel/adis16209.c b/drivers/iio/accel/adis16209.c
index 4a841aec6268..6c2d4a967de7 100644
--- a/drivers/iio/accel/adis16209.c
+++ b/drivers/iio/accel/adis16209.c
@@ -279,7 +279,6 @@ static int adis16209_probe(struct spi_device *spi)
return -ENOMEM;

st = iio_priv(indio_dev);
- spi_set_drvdata(spi, indio_dev);

indio_dev->name = spi->dev.driver->name;
indio_dev->info = &adis16209_info;
--
2.17.1

2020-11-21 15:49:00

by Jonathan Cameron

Subject: Re: [PATCH] iio: accel: adis16209: remove unneeded spi_set_drvdata()

On Thu, 19 Nov 2020 16:18:06 +0200
Alexandru Ardelean <[email protected]> wrote:

> There is no matching spi_get_drvdata() in the driver. This looks like a
> left-over from before the driver was converted to device-managed functions.
>
> Signed-off-by: Alexandru Ardelean <[email protected]>
Applied

> ---
> drivers/iio/accel/adis16209.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adis16209.c b/drivers/iio/accel/adis16209.c
> index 4a841aec6268..6c2d4a967de7 100644
> --- a/drivers/iio/accel/adis16209.c
> +++ b/drivers/iio/accel/adis16209.c
> @@ -279,7 +279,6 @@ static int adis16209_probe(struct spi_device *spi)
> return -ENOMEM;
>
> st = iio_priv(indio_dev);
> - spi_set_drvdata(spi, indio_dev);
>
> indio_dev->name = spi->dev.driver->name;
> indio_dev->info = &adis16209_info;