2020-11-20 08:41:29

by Xu Wang

[permalink] [raw]
Subject: [PATCH] scsi: pm8001: remove casting kcalloc

Remove casting the values returned by kcalloc.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/scsi/pm8001/pm8001_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 3cf3e58b6979..ac0e598b8ac2 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -1187,8 +1187,8 @@ pm8001_init_ccb_tag(struct pm8001_hba_info *pm8001_ha, struct Scsi_Host *shost,
goto err_out;

/* Memory region for ccb_info*/
- pm8001_ha->ccb_info = (struct pm8001_ccb_info *)
- kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
+ pm8001_ha->ccb_info =
+ kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
if (!pm8001_ha->ccb_info) {
PM8001_FAIL_DBG(pm8001_ha, pm8001_printk
("Unable to allocate memory for ccb\n"));
--
2.17.1


2020-11-20 09:00:14

by Jinpu Wang

[permalink] [raw]
Subject: Re: [PATCH] scsi: pm8001: remove casting kcalloc

On Fri, Nov 20, 2020 at 9:36 AM Xu Wang <[email protected]> wrote:
>
> Remove casting the values returned by kcalloc.
>
> Signed-off-by: Xu Wang <[email protected]>
Acked-by: Jack Wang <[email protected]>
Thanks Xu!
> ---
> drivers/scsi/pm8001/pm8001_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 3cf3e58b6979..ac0e598b8ac2 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -1187,8 +1187,8 @@ pm8001_init_ccb_tag(struct pm8001_hba_info *pm8001_ha, struct Scsi_Host *shost,
> goto err_out;
>
> /* Memory region for ccb_info*/
> - pm8001_ha->ccb_info = (struct pm8001_ccb_info *)
> - kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
> + pm8001_ha->ccb_info =
> + kcalloc(ccb_count, sizeof(struct pm8001_ccb_info), GFP_KERNEL);
> if (!pm8001_ha->ccb_info) {
> PM8001_FAIL_DBG(pm8001_ha, pm8001_printk
> ("Unable to allocate memory for ccb\n"));
> --
> 2.17.1
>

2020-11-24 03:45:54

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: pm8001: remove casting kcalloc


Xu,

> Remove casting the values returned by kcalloc.

Applied to 5.11/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2020-12-01 05:14:17

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: pm8001: remove casting kcalloc

On Fri, 20 Nov 2020 08:36:48 +0000, Xu Wang wrote:

> Remove casting the values returned by kcalloc.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: pm8001: Remove typecast for pointer returned by kcalloc()
https://git.kernel.org/mkp/scsi/c/27a34943bd89

--
Martin K. Petersen Oracle Linux Engineering