2020-11-20 15:07:28

by Neil Armstrong

Subject: [PATCH] phy: amlogic: meson-axg-mipi-pcie-analog: replace DSI_LANE definitions with BIT() macro

For consistency, replace DSI_LANE definitions with BIT() macro and remove the unused
DSI_LANE_MASK definition.

Suggested-by: Vinod Koul <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
index 6eb21551bdd9..1027ece6ca12 100644
--- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
+++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
@@ -38,12 +38,11 @@
#define HHI_MIPI_CNTL2_CH_EN GENMASK(15, 11)
#define HHI_MIPI_CNTL2_CH0_LP_CTL GENMASK(10, 1)

-#define DSI_LANE_0 (1 << 4)
-#define DSI_LANE_1 (1 << 3)
-#define DSI_LANE_CLK (1 << 2)
-#define DSI_LANE_2 (1 << 1)
-#define DSI_LANE_3 (1 << 0)
-#define DSI_LANE_MASK (0x1F)
+#define DSI_LANE_0 BIT(4)
+#define DSI_LANE_1 BIT(3)
+#define DSI_LANE_CLK BIT(2)
+#define DSI_LANE_2 BIT(1)
+#define DSI_LANE_3 BIT(0)

struct phy_axg_mipi_pcie_analog_priv {
struct phy *phy;
--
2.25.1

2020-11-30 11:06:20

by Vinod Koul

Subject: Re: [PATCH] phy: amlogic: meson-axg-mipi-pcie-analog: replace DSI_LANE definitions with BIT() macro

On 20-11-20, 16:03, Neil Armstrong wrote:
> For consistency, replace DSI_LANE definitions with BIT() macro and remove the unused
> DSI_LANE_MASK definition.

Applied, thanks

--
~Vinod