2020-11-26 09:40:35

by Ruan Shiyang

Subject: [PATCH] fuse: clean up redundant assignment

The 'err' was assigned to -ENOMEM in just few lines above, no need to be
assigned again.

Signed-off-by: Shiyang Ruan <[email protected]>
---
fs/fuse/dir.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index ff7dbeb16f88..f28eb54517ff 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -528,7 +528,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry,
if (!forget)
goto out_err;

- err = -ENOMEM;
ff = fuse_file_alloc(fm);
if (!ff)
goto out_put_forget_req;
--
2.29.2

2020-12-15 01:11:18

by Ruan Shiyang

Subject: Re: [PATCH] fuse: clean up redundant assignment

Hi guys,

any ideas?


--
Thanks,
Ruan Shiyang.

On 2020/11/26 下午12:03, Shiyang Ruan wrote:
> The 'err' was assigned to -ENOMEM in just few lines above, no need to be
> assigned again.
>
> Signed-off-by: Shiyang Ruan <[email protected]>
> ---
> fs/fuse/dir.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index ff7dbeb16f88..f28eb54517ff 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -528,7 +528,6 @@ static int fuse_create_open(struct inode *dir, struct dentry *entry,
> if (!forget)
> goto out_err;
>
> - err = -ENOMEM;
> ff = fuse_file_alloc(fm);
> if (!ff)
> goto out_put_forget_req;
>