2020-11-06 08:24:33

by Kaixu Xia

Subject: [PATCH] netfilter: Remove unnecessary conversion to bool

From: Kaixu Xia <[email protected]>

Here we could use the '!=' expression to fix the following coccicheck
warning:

./net/netfilter/xt_nfacct.c:30:41-46: WARNING: conversion to bool not needed here

Reported-by: Tosk Robot <[email protected]>
Signed-off-by: Kaixu Xia <[email protected]>
---
net/netfilter/xt_nfacct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/xt_nfacct.c b/net/netfilter/xt_nfacct.c
index a97c2259bbc8..7c6bf1c16813 100644
--- a/net/netfilter/xt_nfacct.c
+++ b/net/netfilter/xt_nfacct.c
@@ -27,7 +27,7 @@ static bool nfacct_mt(const struct sk_buff *skb, struct xt_action_param *par)

overquota = nfnl_acct_overquota(xt_net(par), info->nfacct);

- return overquota == NFACCT_UNDERQUOTA ? false : true;
+ return overquota != NFACCT_UNDERQUOTA;
}

static int
--
2.20.0

2020-12-01 08:50:43

by Pablo Neira Ayuso

Subject: Re: [PATCH] netfilter: Remove unnecessary conversion to bool

On Fri, Nov 06, 2020 at 04:20:13PM +0800, [email protected] wrote:
> From: Kaixu Xia <[email protected]>
>
> Here we could use the '!=' expression to fix the following coccicheck
> warning:
>
> ./net/netfilter/xt_nfacct.c:30:41-46: WARNING: conversion to bool not needed here

Applied.