2020-12-03 13:40:39

by Vidya Sagar

[permalink] [raw]
Subject: [PATCH V5 0/5] Enhancements to Tegra194 PCIe driver

This series of patches do some enhancements and some bug fixes to the
Tegra194 PCIe platform driver like
- Fix Vendor-ID corruption
- Update DWC IP version
- Continue with uninitialization sequence even if parts fail
- Check return value of tegra_pcie_init_controller()
- Disable LTSSM during link's L2 entry

V5:
* Rebased the first patch in the series
* Dropped the second patch
* Added Tested-by and Acked-by for rest of the patches

V4:
* Added a new patch to address link-up issues with some of the cards

V3:
* Addressed Bjorn's review comments
* Split earlier patch-4 into two
- Continue with the uninitialization sequence even if some parts fail
- Check return value of tegra_pcie_init_controller() and exit accordingly

V2:
* Addressed Rob's comments. Changed 'Strongly Ordered' to 'nGnRnE'

Vidya Sagar (5):
PCI: tegra: Fix ASPM-L1SS advertisement disable code
PCI: tegra: Set DesignWare IP version
PCI: tegra: Continue unconfig sequence even if parts fail
PCI: tegra: Check return value of tegra_pcie_init_controller()
PCI: tegra: Disable LTSSM during L2 entry

drivers/pci/controller/dwc/pcie-tegra194.c | 74 +++++++++++-----------
1 file changed, 36 insertions(+), 38 deletions(-)

--
2.17.1


2020-12-03 13:40:49

by Vidya Sagar

[permalink] [raw]
Subject: [PATCH V5 2/5] PCI: tegra: Set DesignWare IP version

Set the DesignWare IP version for Tegra194 to 0x490A. This would be used
by the DesigWare sub-system to do any version specific configuration
(Ex:- TD bit programming for ECRC).

Tested-by: Thierry Reding <[email protected]>
Signed-off-by: Vidya Sagar <[email protected]>
Acked-by: Thierry Reding <[email protected]>
---
V5:
* Added Tested-by and Acked-by from Thierry Reding

V4:
* None

V3:
* None

V2:
* None

drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 4c966e9adb2b..59163b735c96 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -1984,6 +1984,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
pci->ops = &tegra_dw_pcie_ops;
pci->n_fts[0] = N_FTS_VAL;
pci->n_fts[1] = FTS_VAL;
+ pci->version = 0x490A;

pp = &pci->pp;
pp->num_vectors = MAX_MSI_IRQS;
--
2.17.1

2020-12-07 16:49:08

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH V5 0/5] Enhancements to Tegra194 PCIe driver

On Thu, 3 Dec 2020 19:04:46 +0530, Vidya Sagar wrote:
> This series of patches do some enhancements and some bug fixes to the
> Tegra194 PCIe platform driver like
> - Fix Vendor-ID corruption
> - Update DWC IP version
> - Continue with uninitialization sequence even if parts fail
> - Check return value of tegra_pcie_init_controller()
> - Disable LTSSM during link's L2 entry
>
> [...]

Applied to pci/dwc, thanks!

[1/5] PCI: tegra: Fix ASPM-L1SS advertisement disable code
https://git.kernel.org/lpieralisi/pci/c/6b6fafc1ab
[2/5] PCI: tegra: Set DesignWare IP version
https://git.kernel.org/lpieralisi/pci/c/01254b6d6b
[3/5] PCI: tegra: Continue unconfig sequence even if parts fail
https://git.kernel.org/lpieralisi/pci/c/b8f0d67149
[4/5] PCI: tegra: Check return value of tegra_pcie_init_controller()
https://git.kernel.org/lpieralisi/pci/c/3d710af75b
[5/5] PCI: tegra: Disable LTSSM during L2 entry
https://git.kernel.org/lpieralisi/pci/c/cf68e3b7a6

Thanks,
Lorenzo