2020-12-06 15:21:13

by Christophe JAILLET

Subject: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

Add an 'of_node_put()' call when a tested device node is not available.

Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")
Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index 90cd243070d7..828c177df03d 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -269,6 +269,7 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,

if (!of_device_is_available(node)) {
netdev_err(mac->net_dev, "pcs-handle node not available\n");
+ of_node_put(node);
return -ENODEV;
}

--
2.27.0

2020-12-07 15:10:21

by Ioana Ciornei

Subject: Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote:
> Add an 'of_node_put()' call when a tested device node is not available.
>
> Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")
> Signed-off-by: Christophe JAILLET <[email protected]>


Reviewed-by: Ioana Ciornei <[email protected]>

Thanks!

> ---
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> index 90cd243070d7..828c177df03d 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -269,6 +269,7 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
>
> if (!of_device_is_available(node)) {
> netdev_err(mac->net_dev, "pcs-handle node not available\n");
> + of_node_put(node);
> return -ENODEV;
> }
>
> --
> 2.27.0
>

2020-12-08 02:02:59

by Jakub Kicinski

Subject: Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

On Mon, 7 Dec 2020 15:04:58 +0000 Ioana Ciornei wrote:
> On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote:
> > Add an 'of_node_put()' call when a tested device node is not available.
> >
> > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")
> > Signed-off-by: Christophe JAILLET <[email protected]>
>
>
> Reviewed-by: Ioana Ciornei <[email protected]>

Applied, thanks!