2020-12-02 08:28:41

by Chris Ruehl

Subject: [PATCH 2/2] devicetree: phy: rockchip-emmc add output-tapdelay-select

Update the rockchip-emmc-phy.txt and add the u32 property
'output-tapdelay-select'. This allow to set the otapdlysec register.

Tested with our customized rk3399 board to tune eMMC.

Signed-off-by: Chris Ruehl <[email protected]>
---
Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
index 3e4d2d79a65d..00aa2d349e55 100644
--- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
+++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
@@ -18,6 +18,9 @@ Optional properties:
If not set, the default value of 50 will be applied.
- enable-strobe-pulldown: Enable internal pull-down for the strobe line.
If not set, pull-down is not used.
+ - output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
+ If not set, the register defaults to 0x4.
+ Maximum value 0xf.

Example:

--
2.20.1

2020-12-07 17:23:42

by Rob Herring (Arm)

Subject: Re: [PATCH 2/2] devicetree: phy: rockchip-emmc add output-tapdelay-select

On Wed, Dec 02, 2020 at 04:25:07PM +0800, Chris Ruehl wrote:
> Update the rockchip-emmc-phy.txt and add the u32 property
> 'output-tapdelay-select'. This allow to set the otapdlysec register.
>
> Tested with our customized rk3399 board to tune eMMC.
>
> Signed-off-by: Chris Ruehl <[email protected]>
> ---
> Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> index 3e4d2d79a65d..00aa2d349e55 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> @@ -18,6 +18,9 @@ Optional properties:
> If not set, the default value of 50 will be applied.
> - enable-strobe-pulldown: Enable internal pull-down for the strobe line.
> If not set, pull-down is not used.
> + - output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
> + If not set, the register defaults to 0x4.
> + Maximum value 0xf.

Needs a vendor prefix.

>
> Example:
>
> --
> 2.20.1
>