2020-12-13 23:28:26

by Icenowy Zheng

[permalink] [raw]

Subject: [RFC PATCH 08/12] dt-bindings: mmc: sunxi: add compatible strings for V831 MMC

---

V831 has MMC controllers similar to the ones on H6.

Add a compatible string for them.

The eMMC controller compatible is not added, because the eMMC controller
is not available on V831, only V833.

Cc: Ulf Hansson <[email protected]>
Cc: [email protected]
Signed-off-by: Icenowy Zheng <[email protected]>
---
.../devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml b/Documentation/devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml
index e82c9a07b6fb..985586cb93b4 100644
--- a/Documentation/devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml
+++ b/Documentation/devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml
@@ -35,6 +35,9 @@ properties:
- items:
- const: allwinner,sun8i-r40-mmc
- const: allwinner,sun50i-a64-mmc
+ - items:
+ - const: allwinner,sun8i-v831-mmc
+ - const: allwinner,sun50i-a64-mmc
- items:
- const: allwinner,sun50i-h5-emmc
- const: allwinner,sun50i-a64-emmc
--
2.28.0

2020-12-14 18:00:18

by Maxime Ripard

[permalink] [raw]

Subject: Re: [RFC PATCH 08/12] dt-bindings: mmc: sunxi: add compatible strings for V831 MMC

---

On Sat, Dec 12, 2020 at 01:03:42PM +0800, Icenowy Zheng wrote:
> V831 has MMC controllers similar to the ones on H6.
>
> Add a compatible string for them.
>
> The eMMC controller compatible is not added, because the eMMC controller
> is not available on V831, only V833.
>
> Cc: Ulf Hansson <[email protected]>
> Cc: [email protected]
> Signed-off-by: Icenowy Zheng <[email protected]>

There's pretty much the same comment than on the H616, it would be great
to not have any mode flags being set by the driver to avoid the mess we
have on the older SoCs right now.

Maxime

---

Attachments:

(No filename) (605.00 B)
signature.asc (235.00 B)
Download all attachments