2020-12-22 13:15:23

by Alexander Lobakin

Subject: [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb

Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
driver always gets built[-in] on every system.
Add missing dependency.

Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
Signed-off-by: Alexander Lobakin <[email protected]>
---
drivers/phy/ingenic/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
index 65d5ea00fc9d..1cb158d7233f 100644
--- a/drivers/phy/ingenic/Makefile
+++ b/drivers/phy/ingenic/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0
-obj-y += phy-ingenic-usb.o
+obj-$(CONFIG_PHY_INGENIC_USB) += phy-ingenic-usb.o
--
2.29.2

2020-12-23 04:31:05

by Vinod Koul

Subject: Re: [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb

On 22-12-20, 13:10, Alexander Lobakin wrote:
> Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
> not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
> driver always gets built[-in] on every system.
> Add missing dependency.

Applied, thanks

--
~Vinod

2020-12-23 14:19:34

by Zhou Yanjie

Subject: Re: [PATCH phy] PHY: Ingenic: fix unconditional build of phy-ingenic-usb

Hi Alexander,

On 2020/12/22 下午9:10, Alexander Lobakin wrote:
> Currently drivers/phy/ingenic/Makefile adds phy-ingenic-usb to targets
> not depending on actual Kconfig symbol CONFIG_PHY_INGENIC_USB, so this
> driver always gets built[-in] on every system.
> Add missing dependency.
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
> Signed-off-by: Alexander Lobakin <[email protected]>
> ---
> drivers/phy/ingenic/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)


Apologize for my carelessness, and

Tested-by: 周琰杰 (Zhou Yanjie) <[email protected]>


Thanks and best regards!


> diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..1cb158d7233f 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
> # SPDX-License-Identifier: GPL-2.0
> -obj-y += phy-ingenic-usb.o
> +obj-$(CONFIG_PHY_INGENIC_USB) += phy-ingenic-usb.o