2020-12-22 19:18:17

by Hui Su

Subject: [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle()

replace '&next->lru != list' with list_entry_is_head().
No functional change.

Signed-off-by: sh <[email protected]>
---
mm/page_reporting.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_reporting.c b/mm/page_reporting.c
index cd8e13d41df4..c50d93ffa252 100644
--- a/mm/page_reporting.c
+++ b/mm/page_reporting.c
@@ -211,7 +211,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
}

/* Rotate any leftover pages to the head of the freelist */
- if (&next->lru != list && !list_is_first(&next->lru, list))
+ if (!list_entry_is_head(next, list, lru) && !list_is_first(&next->lru, list))
list_rotate_to_front(&next->lru, list);

spin_unlock_irq(&zone->lock);
--
2.25.1

2020-12-29 09:19:00

by David Hildenbrand

Subject: Re: [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle()

On 22.12.20 19:27, sh wrote:
> replace '&next->lru != list' with list_entry_is_head().
> No functional change.
>
> Signed-off-by: sh <[email protected]>
> ---
> mm/page_reporting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index cd8e13d41df4..c50d93ffa252 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -211,7 +211,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
> }
>
> /* Rotate any leftover pages to the head of the freelist */
> - if (&next->lru != list && !list_is_first(&next->lru, list))
> + if (!list_entry_is_head(next, list, lru) && !list_is_first(&next->lru, list))
> list_rotate_to_front(&next->lru, list);
>
> spin_unlock_irq(&zone->lock);
>

LGTM

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb