2020-12-23 15:32:53

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] microblaze: do not select TRACING_SUPPORT directly

Microblaze is the only architecture that selects TRACING_SUPPORT.

In my understanding, it is computed by kernel/trace/Kconfig:

config TRACING_SUPPORT
bool
depends on TRACE_IRQFLAGS_SUPPORT
depends on STACKTRACE_SUPPORT
default y

Microblaze enables both TRACE_IRQFLAGS_SUPPORT and STACKTRACE_SUPPORT,
so there is no change in the resulted configuration.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/microblaze/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
index a0e0c43a2852..acd6d0e68089 100644
--- a/arch/microblaze/Kconfig
+++ b/arch/microblaze/Kconfig
@@ -39,7 +39,6 @@ config MICROBLAZE
select OF_EARLY_FLATTREE
select PCI_DOMAINS_GENERIC if PCI
select PCI_SYSCALL if PCI
- select TRACING_SUPPORT
select VIRT_TO_BUS
select CPU_NO_EFFICIENT_FFS
select MMU_GATHER_NO_RANGE
--
2.27.0


2021-01-04 09:46:41

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] microblaze: do not select TRACING_SUPPORT directly



On 23. 12. 20 16:29, Masahiro Yamada wrote:
> Microblaze is the only architecture that selects TRACING_SUPPORT.
>
> In my understanding, it is computed by kernel/trace/Kconfig:
>
> config TRACING_SUPPORT
> bool
> depends on TRACE_IRQFLAGS_SUPPORT
> depends on STACKTRACE_SUPPORT
> default y
>
> Microblaze enables both TRACE_IRQFLAGS_SUPPORT and STACKTRACE_SUPPORT,
> so there is no change in the resulted configuration.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/microblaze/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
> index a0e0c43a2852..acd6d0e68089 100644
> --- a/arch/microblaze/Kconfig
> +++ b/arch/microblaze/Kconfig
> @@ -39,7 +39,6 @@ config MICROBLAZE
> select OF_EARLY_FLATTREE
> select PCI_DOMAINS_GENERIC if PCI
> select PCI_SYSCALL if PCI
> - select TRACING_SUPPORT
> select VIRT_TO_BUS
> select CPU_NO_EFFICIENT_FFS
> select MMU_GATHER_NO_RANGE
>

make sense.

Applied.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs