2020-12-31 04:12:45

by Yi Li

Subject: [PATCH] ocfs2: Remove redundant conditional before iput

iput handles NULL pointers gracefully, so there's no need to
check the pointer before the call.

Signed-off-by: Yi Li <[email protected]>
---
fs/ocfs2/super.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index 2febc76e9de7..079f8826993e 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -973,8 +973,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
* quota files */
dquot_disable(sb, type, DQUOT_USAGE_ENABLED |
DQUOT_LIMITS_ENABLED);
- if (!inode)
- continue;
iput(inode);
}
}
--
2.25.3

2020-12-31 04:36:01

by Joseph Qi

Subject: Re: [PATCH] ocfs2: Remove redundant conditional before iput

On 12/31/20 12:05 PM, Yi Li wrote:
> iput handles NULL pointers gracefully, so there's no need to
> check the pointer before the call.
>
> Signed-off-by: Yi Li <[email protected]>

Acked-by: Joseph Qi <[email protected]>
> ---
> fs/ocfs2/super.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
> index 2febc76e9de7..079f8826993e 100644
> --- a/fs/ocfs2/super.c
> +++ b/fs/ocfs2/super.c
> @@ -973,8 +973,6 @@ static void ocfs2_disable_quotas(struct ocfs2_super *osb)
> * quota files */
> dquot_disable(sb, type, DQUOT_USAGE_ENABLED |
> DQUOT_LIMITS_ENABLED);
> - if (!inode)
> - continue;
> iput(inode);
> }
> }
>