2021-01-04 12:43:25

by Kishon Vijay Abraham I

Subject: [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector

Add binding to represent refclk to the PCIe connector.

Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
.../bindings/pci/ti,j721e-pci-host.yaml | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 0880a613ece6..7607018a115b 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -46,12 +46,21 @@ properties:
maxItems: 1

clocks:
- maxItems: 1
- description: clock-specifier to represent input to the PCIe
+ minItems: 1
+ maxItems: 2
+ description: clock-specifier to represent input to the PCIe for 1 item.
+ 2nd item if present represents reference clock to the connector.

clock-names:
- items:
- - const: fck
+ oneOf:
+ - description: Represent input clock to the PCIe
+ items:
+ - const: fck
+ - description: Represent input clock to the PCIe and reference clock to
+ the connector.
+ items:
+ - const: fck
+ - const: pcie_refclk

vendor-id:
const: 0x104c
--
2.17.1

2021-01-11 22:34:50

by Rob Herring (Arm)

Subject: Re: [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector

On Mon, Jan 04, 2021 at 06:11:00PM +0530, Kishon Vijay Abraham I wrote:
> Add binding to represent refclk to the PCIe connector.
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> .../bindings/pci/ti,j721e-pci-host.yaml | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 0880a613ece6..7607018a115b 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -46,12 +46,21 @@ properties:
> maxItems: 1
>
> clocks:
> - maxItems: 1
> - description: clock-specifier to represent input to the PCIe
> + minItems: 1
> + maxItems: 2
> + description: clock-specifier to represent input to the PCIe for 1 item.
> + 2nd item if present represents reference clock to the connector.
>
> clock-names:
> - items:
> - - const: fck
> + oneOf:
> + - description: Represent input clock to the PCIe
> + items:
> + - const: fck
> + - description: Represent input clock to the PCIe and reference clock to
> + the connector.
> + items:
> + - const: fck
> + - const: pcie_refclk

Can be just:

minItems: 1
items:
- const: fck
- const: pcie_refclk