2021-01-06 14:07:44

by Petr Štetiar

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7915: fix misplaced #ifdef

Arnd Bergmann <[email protected]> [2021-01-03 14:57:55]:

Hi,

just a small nitpick,

> From: Arnd Bergmann <[email protected]>
>
> The lone '|' at the end of a line causes a build failure:
>
> drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error: expected expression before '}' token
>
> Replace the #ifdef with an equivalent IS_ENABLED() check.
>
> Fixes: af901eb4ab80 ("mt76: mt7915: get rid of dbdc debugfs knob")

I think, that the correct fixes tag is following:

Fixes: 8aa2c6f4714e ("mt76: mt7915: support 32 station interfaces")

I've used the af901eb4ab80 as well first in
https://github.com/openwrt/mt76/pull/490 but then looked at it once more and
actually found the probably correct 8aa2c6f4714e.

Cheers,

Petr


2021-01-14 10:46:52

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7915: fix misplaced #ifdef

Petr Štetiar <[email protected]> writes:

> Arnd Bergmann <[email protected]> [2021-01-03 14:57:55]:
>
> Hi,
>
> just a small nitpick,
>
>> From: Arnd Bergmann <[email protected]>
>>
>> The lone '|' at the end of a line causes a build failure:
>>
>> drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error:
>> expected expression before '}' token
>>
>> Replace the #ifdef with an equivalent IS_ENABLED() check.
>>
>> Fixes: af901eb4ab80 ("mt76: mt7915: get rid of dbdc debugfs knob")
>
> I think, that the correct fixes tag is following:
>
> Fixes: 8aa2c6f4714e ("mt76: mt7915: support 32 station interfaces")
>
> I've used the af901eb4ab80 as well first in
> https://github.com/openwrt/mt76/pull/490 but then looked at it once more and
> actually found the probably correct 8aa2c6f4714e.

Ok, I'll change that during commit.

Felix, I'm planning to apply this to wireless-drivers and assigned this
to me in patchwork.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches