2021-01-17 09:03:30

by Dinghao Liu

Subject: [PATCH] block: Fix an error handling in add_partition

Once we have called device_initialize(), we should use put_device() to
give up the reference on error, just like what we have done on failure
of device_add().

Signed-off-by: Dinghao Liu <[email protected]>
---

Changelog:

v2: - Refine commit message.
---
block/partitions/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index e7d776db803b..23460cee9de5 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,

err = blk_alloc_devt(bdev, &devt);
if (err)
- goto out_bdput;
+ goto out_put;
pdev->devt = devt;

/* delay uevent until 'holders' subdir is created */
--
2.17.1

2021-01-20 10:35:58

by Christoph Hellwig

Subject: Re: [PATCH] block: Fix an error handling in add_partition

On Sun, Jan 17, 2021 at 04:50:17PM +0800, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>
> Signed-off-by: Dinghao Liu <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2021-01-25 04:38:50

by Jens Axboe

Subject: Re: [PATCH] block: Fix an error handling in add_partition

On 1/17/21 1:50 AM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().

Applied for 5.11, thanks.

--
Jens Axboe