2021-01-26 10:52:25

by Ruan Shiyang

Subject: [PATCH] dax: fix default return code of range_parse()

The return value of range_parse() indicates the size when it is
positive. The error code should be negative.

Signed-off-by: Shiyang Ruan <[email protected]>
---
drivers/dax/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index 737b207c9e30..3003558c1a8b 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -1038,7 +1038,7 @@ static ssize_t range_parse(const char *opt, size_t len, struct range *range)
{
unsigned long long addr = 0;
char *start, *end, *str;
- ssize_t rc = EINVAL;
+ ssize_t rc = -EINVAL;

str = kstrdup(opt, GFP_KERNEL);
if (!str)
--
2.30.0

2021-02-08 05:52:09

by Ruan Shiyang

Subject: Re: [PATCH] dax: fix default return code of range_parse()

ping

On 2021/1/26 上午10:13, Shiyang Ruan wrote:
> The return value of range_parse() indicates the size when it is
> positive. The error code should be negative.
>
> Signed-off-by: Shiyang Ruan <[email protected]>
> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 737b207c9e30..3003558c1a8b 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -1038,7 +1038,7 @@ static ssize_t range_parse(const char *opt, size_t len, struct range *range)
> {
> unsigned long long addr = 0;
> char *start, *end, *str;
> - ssize_t rc = EINVAL;
> + ssize_t rc = -EINVAL;
>
> str = kstrdup(opt, GFP_KERNEL);
> if (!str)
>

2021-02-10 18:33:08

by Joao Martins

Subject: Re: [PATCH] dax: fix default return code of range_parse()

On 1/26/21 2:13 AM, Shiyang Ruan wrote:
> The return value of range_parse() indicates the size when it is
> positive. The error code should be negative.
>
> Signed-off-by: Shiyang Ruan <[email protected]>

Reviewed-by: Joao Martins <[email protected]>

Although, FWIW, there was another patch exactly like this a couple
months ago, albeit it didn't get pulled for some reason:

https://lore.kernel.org/linux-nvdimm/[email protected]/

> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 737b207c9e30..3003558c1a8b 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -1038,7 +1038,7 @@ static ssize_t range_parse(const char *opt, size_t len, struct range *range)
> {
> unsigned long long addr = 0;
> char *start, *end, *str;
> - ssize_t rc = EINVAL;
> + ssize_t rc = -EINVAL;
>
> str = kstrdup(opt, GFP_KERNEL);
> if (!str)
>

2021-02-16 22:41:21

by Dan Williams

Subject: Re: [PATCH] dax: fix default return code of range_parse()

On Wed, Feb 10, 2021 at 10:19 AM Joao Martins <[email protected]> wrote:
>
> On 1/26/21 2:13 AM, Shiyang Ruan wrote:
> > The return value of range_parse() indicates the size when it is
> > positive. The error code should be negative.
> >
> > Signed-off-by: Shiyang Ruan <[email protected]>
>
> Reviewed-by: Joao Martins <[email protected]>
>
> Although, FWIW, there was another patch exactly like this a couple
> months ago, albeit it didn't get pulled for some reason:
>
> https://lore.kernel.org/linux-nvdimm/[email protected]/

Apologies for missing these... applied now.