2021-01-27 21:24:26

by Yue Hu

Subject: [PATCH] init/Kconfig: correct thermal pressure retrieve API

From: Yue Hu <[email protected]>

We're using arch_scale_thermal_pressure() to retrieve per CPU thermal
pressure.

Signed-off-by: Yue Hu <[email protected]>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index c4e0a7e..5b35e15 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -525,7 +525,7 @@ config SCHED_THERMAL_PRESSURE
i.e. put less load on throttled CPUs than on non/less throttled ones.

This requires the architecture to implement
- arch_set_thermal_pressure() and arch_get_thermal_pressure().
+ arch_set_thermal_pressure() and arch_scale_thermal_pressure().

config BSD_PROCESS_ACCT
bool "BSD Process Accounting"
--
1.9.1

2021-01-27 22:13:41

by Valentin Schneider

Subject: Re: [PATCH] init/Kconfig: correct thermal pressure retrieve API

On 27/01/21 13:44, Yue Hu wrote:
> From: Yue Hu <[email protected]>
>
> We're using arch_scale_thermal_pressure() to retrieve per CPU thermal
> pressure.
>
> Signed-off-by: Yue Hu <[email protected]>

Whoever wrote that clearly got "arch" and "topology" mixed up!

Reviewed-by: Valentin Schneider <[email protected]>

> ---
> init/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index c4e0a7e..5b35e15 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -525,7 +525,7 @@ config SCHED_THERMAL_PRESSURE
> i.e. put less load on throttled CPUs than on non/less throttled ones.
>
> This requires the architecture to implement
> - arch_set_thermal_pressure() and arch_get_thermal_pressure().
> + arch_set_thermal_pressure() and arch_scale_thermal_pressure().
>
> config BSD_PROCESS_ACCT
> bool "BSD Process Accounting"
> --
> 1.9.1