2021-02-01 23:00:01

by Rikard Falkeborn

Subject: [PATCH] PM: Constify static struct attribute_group

The only usage of suspend_attr_group is to put its address in an array of
pointers to const attribute_group structs. Make it const to allow the
compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <[email protected]>
---
kernel/power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/main.c b/kernel/power/main.c
index 0aefd6f57e0a..12c7e1bb442f 100644
--- a/kernel/power/main.c
+++ b/kernel/power/main.c
@@ -387,7 +387,7 @@ static struct attribute *suspend_attrs[] = {
NULL,
};

-static struct attribute_group suspend_attr_group = {
+static const struct attribute_group suspend_attr_group = {
.name = "suspend_stats",
.attrs = suspend_attrs,
};
--
2.30.0

2021-02-12 15:52:55

by Rafael J. Wysocki

Subject: Re: [PATCH] PM: Constify static struct attribute_group

On Mon, Feb 1, 2021 at 11:58 PM Rikard Falkeborn
<[email protected]> wrote:
>
> The only usage of suspend_attr_group is to put its address in an array of
> pointers to const attribute_group structs. Make it const to allow the
> compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <[email protected]>
> ---
> kernel/power/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 0aefd6f57e0a..12c7e1bb442f 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -387,7 +387,7 @@ static struct attribute *suspend_attrs[] = {
> NULL,
> };
>
> -static struct attribute_group suspend_attr_group = {
> +static const struct attribute_group suspend_attr_group = {
> .name = "suspend_stats",
> .attrs = suspend_attrs,
> };
> --

Applied as 5.12 material, thanks!