2021-02-05 02:07:49

by Benjamin Li

Subject: [PATCH v2 0/2] Clean up MSM8939 interconnect driver

Following up on a review comment on commit 6c6fe5d3dc5e ("interconnect: qcom:
Add MSM8939 interconnect provider driver") to clean up some log pollution.

This is based on icc-next (which appears to contain a refactor commonizing
functions into icc-rpm.c).

v2:
- Update commit message to add a full explanation, rather than referencing a
previous commit.

Benjamin Li (2):
interconnect: qcom: icc-rpm: record slave RPM id in error log
interconnect: qcom: msm8939: remove rpm-ids from non-RPM nodes

drivers/interconnect/qcom/icc-rpm.c | 4 ++--
drivers/interconnect/qcom/msm8939.c | 16 ++++++++--------
2 files changed, 10 insertions(+), 10 deletions(-)

--
2.17.1

2021-02-05 02:07:57

by Benjamin Li

Subject: [PATCH v2 1/2] interconnect: qcom: icc-rpm: record slave RPM id in error log

Add slave RPM ID to assist with identifying incorrect RPM config.

Signed-off-by: Benjamin Li <[email protected]>
---
drivers/interconnect/qcom/icc-rpm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
index cc6095492cbe..54de49ca7808 100644
--- a/drivers/interconnect/qcom/icc-rpm.c
+++ b/drivers/interconnect/qcom/icc-rpm.c
@@ -59,8 +59,8 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
qn->slv_rpm_id,
sum_bw);
if (ret) {
- pr_err("qcom_icc_rpm_smd_send slv error %d\n",
- ret);
+ pr_err("qcom_icc_rpm_smd_send slv %d error %d\n",
+ qn->slv_rpm_id, ret);
return ret;
}
}
--
2.17.1

2021-02-05 03:05:31

by Jun Nie

Subject: Re: [PATCH v2 0/2] Clean up MSM8939 interconnect driver

Benjamin Li <[email protected]> 于2021年2月5日周五 上午9:52写道：
>
> Following up on a review comment on commit 6c6fe5d3dc5e ("interconnect: qcom:
> Add MSM8939 interconnect provider driver") to clean up some log pollution.
>
> This is based on icc-next (which appears to contain a refactor commonizing
> functions into icc-rpm.c).
>
> v2:
> - Update commit message to add a full explanation, rather than referencing a
> previous commit.
>
> Benjamin Li (2):
> interconnect: qcom: icc-rpm: record slave RPM id in error log
> interconnect: qcom: msm8939: remove rpm-ids from non-RPM nodes
>
> drivers/interconnect/qcom/icc-rpm.c | 4 ++--
> drivers/interconnect/qcom/msm8939.c | 16 ++++++++--------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> --
> 2.17.1
>

For 2 patches:
Reviewed-by: Jun Nie <[email protected]>