2021-02-12 04:42:14

by Ian Rogers

Subject: [PATCH] perf libperf: Remove unused xyarray.c

Migrated to libperf in:
commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")

Signed-off-by: Ian Rogers <[email protected]>
---
tools/perf/util/xyarray.c | 33 ---------------------------------
1 file changed, 33 deletions(-)
delete mode 100644 tools/perf/util/xyarray.c

diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
deleted file mode 100644
index 86889ebc3514..000000000000
--- a/tools/perf/util/xyarray.c
+++ /dev/null
@@ -1,33 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include "xyarray.h"
-#include <stdlib.h>
-#include <string.h>
-#include <linux/zalloc.h>
-
-struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
-{
- size_t row_size = ylen * entry_size;
- struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
-
- if (xy != NULL) {
- xy->entry_size = entry_size;
- xy->row_size = row_size;
- xy->entries = xlen * ylen;
- xy->max_x = xlen;
- xy->max_y = ylen;
- }
-
- return xy;
-}
-
-void xyarray__reset(struct xyarray *xy)
-{
- size_t n = xy->entries * xy->entry_size;
-
- memset(xy->contents, 0, n);
-}
-
-void xyarray__delete(struct xyarray *xy)
-{
- free(xy);
-}
--
2.30.0.478.g8a0d178c01-goog

2021-02-12 08:38:36

by Jiri Olsa

Subject: Re: [PATCH] perf libperf: Remove unused xyarray.c

On Thu, Feb 11, 2021 at 08:38:03PM -0800, Ian Rogers wrote:
> Migrated to libperf in:
> commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")

Acked-by: Jiri Olsa <[email protected]>

thanks,
jirka

>
> Signed-off-by: Ian Rogers <[email protected]>
> ---
> tools/perf/util/xyarray.c | 33 ---------------------------------
> 1 file changed, 33 deletions(-)
> delete mode 100644 tools/perf/util/xyarray.c
>
> diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
> deleted file mode 100644
> index 86889ebc3514..000000000000
> --- a/tools/perf/util/xyarray.c
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -#include "xyarray.h"
> -#include <stdlib.h>
> -#include <string.h>
> -#include <linux/zalloc.h>
> -
> -struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
> -{
> - size_t row_size = ylen * entry_size;
> - struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
> -
> - if (xy != NULL) {
> - xy->entry_size = entry_size;
> - xy->row_size = row_size;
> - xy->entries = xlen * ylen;
> - xy->max_x = xlen;
> - xy->max_y = ylen;
> - }
> -
> - return xy;
> -}
> -
> -void xyarray__reset(struct xyarray *xy)
> -{
> - size_t n = xy->entries * xy->entry_size;
> -
> - memset(xy->contents, 0, n);
> -}
> -
> -void xyarray__delete(struct xyarray *xy)
> -{
> - free(xy);
> -}
> --
> 2.30.0.478.g8a0d178c01-goog
>

2021-02-12 20:29:27

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf libperf: Remove unused xyarray.c

Em Fri, Feb 12, 2021 at 09:33:58AM +0100, Jiri Olsa escreveu:
> On Thu, Feb 11, 2021 at 08:38:03PM -0800, Ian Rogers wrote:
> > Migrated to libperf in:
> > commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")
>
> Acked-by: Jiri Olsa <[email protected]>

Thanks, applied.

- Arnaldo


> thanks,
> jirka
>
> >
> > Signed-off-by: Ian Rogers <[email protected]>
> > ---
> > tools/perf/util/xyarray.c | 33 ---------------------------------
> > 1 file changed, 33 deletions(-)
> > delete mode 100644 tools/perf/util/xyarray.c
> >
> > diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
> > deleted file mode 100644
> > index 86889ebc3514..000000000000
> > --- a/tools/perf/util/xyarray.c
> > +++ /dev/null
> > @@ -1,33 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > -#include "xyarray.h"
> > -#include <stdlib.h>
> > -#include <string.h>
> > -#include <linux/zalloc.h>
> > -
> > -struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
> > -{
> > - size_t row_size = ylen * entry_size;
> > - struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
> > -
> > - if (xy != NULL) {
> > - xy->entry_size = entry_size;
> > - xy->row_size = row_size;
> > - xy->entries = xlen * ylen;
> > - xy->max_x = xlen;
> > - xy->max_y = ylen;
> > - }
> > -
> > - return xy;
> > -}
> > -
> > -void xyarray__reset(struct xyarray *xy)
> > -{
> > - size_t n = xy->entries * xy->entry_size;
> > -
> > - memset(xy->contents, 0, n);
> > -}
> > -
> > -void xyarray__delete(struct xyarray *xy)
> > -{
> > - free(xy);
> > -}
> > --
> > 2.30.0.478.g8a0d178c01-goog
> >
>

--

- Arnaldo