2021-02-14 06:57:55

by Wei Ming Chen

Subject: [PATCH] Fix typo in f_printer.c

In line 824, it is trying to open `out_ep`, so
I believe in line 826, it should print `out_ep`
instead of `in_ep`

Signed-off-by: AristoChen <[email protected]>
---
drivers/usb/gadget/function/f_printer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index 2f1eb2e81d30..a3b17ec00bf0 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)

result = usb_ep_enable(dev->out_ep);
if (result != 0) {
- DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
+ DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
goto done;
}

--
2.25.1

2021-02-14 07:22:20

by Randy Dunlap

Subject: Re: [PATCH] Fix typo in f_printer.c

On 2/13/21 10:53 PM, AristoChen wrote:
> In line 824, it is trying to open `out_ep`, so
> I believe in line 826, it should print `out_ep`
> instead of `in_ep`
>
> Signed-off-by: AristoChen <[email protected]>
> ---
> drivers/usb/gadget/function/f_printer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
> index 2f1eb2e81d30..a3b17ec00bf0 100644
> --- a/drivers/usb/gadget/function/f_printer.c
> +++ b/drivers/usb/gadget/function/f_printer.c
> @@ -823,7 +823,7 @@ set_printer_interface(struct printer_dev *dev)
>
> result = usb_ep_enable(dev->out_ep);
> if (result != 0) {
> - DBG(dev, "enable %s --> %d\n", dev->in_ep->name, result);
> + DBG(dev, "enable %s --> %d\n", dev->out_ep->name, result);
> goto done;
> }
>
>

Hi,
The patch makes sense.
You should Cc: the USB gadget maintainer and the linux-usb mailing list.

Thanks.