changes since previous version:
- change Subject line
- change commit message
- change commit message position to above signed-off-by
checkpatch gives the following WARNING:
WARNING: Comparisons should place the constant on the right side of the test
this patch fixes the coding style warning.
Signed-off-by: Kurt Manucredo <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 975f2830e29e..96feced698ac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr)
struct security_priv *psecpriv = &padapter->securitypriv;
memset(pcur_dot11txpn, 0, 8);
- if (NULL == StaAddr)
+ if (!StaAddr)
return;
psta = rtw_get_stainfo(&padapter->stapriv, StaAddr);
DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n",
--
2.20.1
On Fri, Feb 19, 2021 at 02:50:53PM +0000, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
>
These comments need to go below the --- cut off line.
> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo <[email protected]>
> ---
^^^
This one here.
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
regards,
dan carpenter
On Fri, Feb 19, 2021 at 02:50:53PM +0000, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
This all goes below the --- line please.
Please make a v3.
thanks,
greg k-h