2021-03-08 08:41:43

by Jia-Ju Bai

Subject: [PATCH] scsi: qedi: fix error return code of qedi_alloc_global_queues()

When kzalloc() returns NULL to qedi->global_queues[i], no error return
code of qedi_alloc_global_queues() is assigned.
To fix this bug, status is assigned with -ENOMEM in this case.

Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Reported-by: TOTE Robot <[email protected]>
Signed-off-by: Jia-Ju Bai <[email protected]>
---
drivers/scsi/qedi/qedi_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 47ad64b06623..69c5b5ee2169 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1675,6 +1675,7 @@ static int qedi_alloc_global_queues(struct qedi_ctx *qedi)
if (!qedi->global_queues[i]) {
QEDI_ERR(&qedi->dbg_ctx,
"Unable to allocation global queue %d.\n", i);
+ status = -ENOMEM;
goto mem_alloc_failure;
}

--
2.17.1

2021-03-22 14:47:34

by Manish Rangankar

Subject: RE: [EXT] [PATCH] scsi: qedi: fix error return code of qedi_alloc_global_queues()

> -----Original Message-----
> From: Jia-Ju Bai <[email protected]>
> Sent: Monday, March 8, 2021 9:00 AM
> To: Nilesh Javali <[email protected]>; Manish Rangankar
> <[email protected]>; [email protected];
> [email protected]
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> [email protected]>; [email protected]; linux-
> [email protected]; Jia-Ju Bai <[email protected]>
> Subject: [EXT] [PATCH] scsi: qedi: fix error return code of
> qedi_alloc_global_queues()
>
> External Email
>
> ----------------------------------------------------------------------
> When kzalloc() returns NULL to qedi->global_queues[i], no error return code of
> qedi_alloc_global_queues() is assigned.
> To fix this bug, status is assigned with -ENOMEM in this case.
>
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver
> framework.")
> Reported-by: TOTE Robot <[email protected]>
> Signed-off-by: Jia-Ju Bai <[email protected]>
> ---
> drivers/scsi/qedi/qedi_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index
> 47ad64b06623..69c5b5ee2169 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1675,6 +1675,7 @@ static int qedi_alloc_global_queues(struct qedi_ctx
> *qedi)
> if (!qedi->global_queues[i]) {
> QEDI_ERR(&qedi->dbg_ctx,
> "Unable to allocation global queue %d.\n", i);
> + status = -ENOMEM;
> goto mem_alloc_failure;
> }
>
> --
> 2.17.1

Thanks,
Acked-by: Manish Rangankar <[email protected]>

2021-03-25 03:58:51

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qedi: fix error return code of qedi_alloc_global_queues()

On Sun, 7 Mar 2021 19:30:24 -0800, Jia-Ju Bai wrote:

> When kzalloc() returns NULL to qedi->global_queues[i], no error return
> code of qedi_alloc_global_queues() is assigned.
> To fix this bug, status is assigned with -ENOMEM in this case.

Applied to 5.12/scsi-fixes, thanks!

[1/1] scsi: qedi: fix error return code of qedi_alloc_global_queues()
https://git.kernel.org/mkp/scsi/c/f69953837ca5

--
Martin K. Petersen Oracle Linux Engineering