2021-02-13 12:26:00

by Orson Zhai

Subject: [PATCH v2 2/3] dt-bindings: mailbox: Add interrupt-names to SPRD mailbox

From: Orson Zhai <[email protected]>

We add an optional supp-outbox interrupt support to SPRD mailbox driver
with newly added sc9863a support and change to configure interrupts with
names in device tree files.

Signed-off-by: Orson Zhai <[email protected]>
---
.../bindings/mailbox/sprd-mailbox.yaml | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
index 26a5cca3f838..67736450ee93 100644
--- a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
+++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
@@ -15,6 +15,7 @@ properties:
compatible:
enum:
- sprd,sc9860-mailbox
+ - sprd,sc9863a-mailbox

reg:
items:
@@ -22,9 +23,18 @@ properties:
- description: outbox registers' base address

interrupts:
- items:
- - description: inbox interrupt
- - description: outbox interrupt
+ minItems: 2
+ maxItems: 3
+
+ interrupt-names:
+ oneOf:
+ - items:
+ - const: inbox
+ - const: outbox
+ - items:
+ - const: inbox
+ - const: outbox
+ - const: supp-outbox

clocks:
maxItems: 1
@@ -40,6 +50,7 @@ required:
- compatible
- reg
- interrupts
+ - interrupt-names
- "#mbox-cells"
- clocks
- clock-names
@@ -56,5 +67,6 @@ examples:
clock-names = "enable";
clocks = <&aon_gate 53>;
interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "inbox", "outbox";
};
...
--
2.17.1

2021-03-05 21:24:43

by Rob Herring (Arm)

Subject: Re: [PATCH v2 2/3] dt-bindings: mailbox: Add interrupt-names to SPRD mailbox

On Sat, Feb 13, 2021 at 08:21:42PM +0800, Orson Zhai wrote:
> From: Orson Zhai <[email protected]>
>
> We add an optional supp-outbox interrupt support to SPRD mailbox driver
> with newly added sc9863a support and change to configure interrupts with
> names in device tree files.
>
> Signed-off-by: Orson Zhai <[email protected]>
> ---
> .../bindings/mailbox/sprd-mailbox.yaml | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> index 26a5cca3f838..67736450ee93 100644
> --- a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> @@ -15,6 +15,7 @@ properties:
> compatible:
> enum:
> - sprd,sc9860-mailbox
> + - sprd,sc9863a-mailbox
>
> reg:
> items:
> @@ -22,9 +23,18 @@ properties:
> - description: outbox registers' base address
>
> interrupts:
> - items:
> - - description: inbox interrupt
> - - description: outbox interrupt
> + minItems: 2
> + maxItems: 3
> +
> + interrupt-names:
> + oneOf:
> + - items:
> + - const: inbox
> + - const: outbox
> + - items:
> + - const: inbox
> + - const: outbox
> + - const: supp-outbox

You can do this instead:

interrupt-names:
minItems: 2
items:
- const: inbox
- const: outbox
- const: supp-outbox

>
> clocks:
> maxItems: 1
> @@ -40,6 +50,7 @@ required:
> - compatible
> - reg
> - interrupts
> + - interrupt-names
> - "#mbox-cells"
> - clocks
> - clock-names
> @@ -56,5 +67,6 @@ examples:
> clock-names = "enable";
> clocks = <&aon_gate 53>;
> interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "inbox", "outbox";
> };
> ...
> --
> 2.17.1
>

2021-03-08 08:46:21

by Orson Zhai

Subject: Re: [PATCH v2 2/3] dt-bindings: mailbox: Add interrupt-names to SPRD mailbox

Hi Rob,

On Fri, Mar 05, 2021 at 03:22:21PM -0600, Rob Herring wrote:
> On Sat, Feb 13, 2021 at 08:21:42PM +0800, Orson Zhai wrote:
> > From: Orson Zhai <[email protected]>
> >
> > We add an optional supp-outbox interrupt support to SPRD mailbox driver
> > with newly added sc9863a support and change to configure interrupts with
> > names in device tree files.
> >
> > Signed-off-by: Orson Zhai <[email protected]>
> > ---
> > .../bindings/mailbox/sprd-mailbox.yaml | 18 +++++++++++++++---
> > 1 file changed, 15 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> > index 26a5cca3f838..67736450ee93 100644
> > --- a/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/sprd-mailbox.yaml
> > @@ -15,6 +15,7 @@ properties:
> > compatible:
> > enum:
> > - sprd,sc9860-mailbox
> > + - sprd,sc9863a-mailbox
> >
> > reg:
> > items:
> > @@ -22,9 +23,18 @@ properties:
> > - description: outbox registers' base address
> >
> > interrupts:
> > - items:
> > - - description: inbox interrupt
> > - - description: outbox interrupt
> > + minItems: 2
> > + maxItems: 3
> > +
> > + interrupt-names:
> > + oneOf:
> > + - items:
> > + - const: inbox
> > + - const: outbox
> > + - items:
> > + - const: inbox
> > + - const: outbox
> > + - const: supp-outbox
>
> You can do this instead:
>
> interrupt-names:
> minItems: 2
> items:
> - const: inbox
> - const: outbox
> - const: supp-outbox

Does this mean only the first 2 items in the minimum range?

For example, "inbox" + "supp-outbox" is not supposed to be a valid combination.

Only "supp-outbox" is optional and the other two are mandatory.

Best,
Orson

>
> >
> > clocks:
> > maxItems: 1
> > @@ -40,6 +50,7 @@ required:
> > - compatible
> > - reg
> > - interrupts
> > + - interrupt-names
> > - "#mbox-cells"
> > - clocks
> > - clock-names
> > @@ -56,5 +67,6 @@ examples:
> > clock-names = "enable";
> > clocks = <&aon_gate 53>;
> > interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "inbox", "outbox";
> > };
> > ...
> > --
> > 2.17.1
> >