2021-03-08 11:57:49

by quanyang wang

Subject: [PATCH] arm64: dts: zynqmp: Remove si5328 device nodes

From: Quanyang Wang <[email protected]>

The function of_i2c_get_board_info will call of_modalias_node to check
if a device_node contains "compatible" string. But for the device si5328
at zcu102/zcu106 boards, there is no proper DT bindings for them. So remove
si5328 device nodes from dts files to eliminate the error info in the boot
message:

i2c i2c-10: of_i2c: modalias failure on /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
i2c i2c-10: Failed to create I2C device for /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69

Signed-off-by: Quanyang Wang <[email protected]>
---
.../boot/dts/xilinx/zynqmp-zcu102-revA.dts | 20 +------------------
.../boot/dts/xilinx/zynqmp-zcu106-revA.dts | 20 +------------------
2 files changed, 2 insertions(+), 38 deletions(-)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
index 12e8bd48dc8c..eca6c2de84a7 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
@@ -580,25 +580,7 @@ i2c@4 {
#address-cells = <1>;
#size-cells = <0>;
reg = <4>;
- si5328: clock-generator@69 {/* SI5328 - u20 */
- reg = <0x69>;
- /*
- * Chip has interrupt present connected to PL
- * interrupt-parent = <&>;
- * interrupts = <>;
- */
- #address-cells = <1>;
- #size-cells = <0>;
- #clock-cells = <1>;
- clocks = <&refhdmi>;
- clock-names = "xtal";
- clock-output-names = "si5328";
-
- si5328_clk: clk0@0 {
- reg = <0>;
- clock-frequency = <27000000>;
- };
- };
+ /* SI5328 - u20 */
};
/* 5 - 7 unconnected */
};
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
index 18771e868399..eff7c6447087 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
@@ -581,25 +581,7 @@ i2c@4 {
#address-cells = <1>;
#size-cells = <0>;
reg = <4>;
- si5328: clock-generator@69 {/* SI5328 - u20 */
- reg = <0x69>;
- /*
- * Chip has interrupt present connected to PL
- * interrupt-parent = <&>;
- * interrupts = <>;
- */
- #address-cells = <1>;
- #size-cells = <0>;
- #clock-cells = <1>;
- clocks = <&refhdmi>;
- clock-names = "xtal";
- clock-output-names = "si5328";
-
- si5328_clk: clk0@0 {
- reg = <0>;
- clock-frequency = <27000000>;
- };
- };
+ /* SI5328 - u20 */
};
i2c@5 {
#address-cells = <1>;
--
2.25.1

2021-03-08 16:30:10

by Michal Simek

Subject: Re: [PATCH] arm64: dts: zynqmp: Remove si5328 device nodes

On 3/8/21 12:54 PM, [email protected] wrote:
> From: Quanyang Wang <[email protected]>
>
> The function of_i2c_get_board_info will call of_modalias_node to check
> if a device_node contains "compatible" string. But for the device si5328
> at zcu102/zcu106 boards, there is no proper DT bindings for them. So remove
> si5328 device nodes from dts files to eliminate the error info in the boot
> message:
>
> i2c i2c-10: of_i2c: modalias failure on /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
> i2c i2c-10: Failed to create I2C device for /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
>
> Signed-off-by: Quanyang Wang <[email protected]>
> ---
> .../boot/dts/xilinx/zynqmp-zcu102-revA.dts | 20 +------------------
> .../boot/dts/xilinx/zynqmp-zcu106-revA.dts | 20 +------------------
> 2 files changed, 2 insertions(+), 38 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index 12e8bd48dc8c..eca6c2de84a7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -580,25 +580,7 @@ i2c@4 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <4>;
> - si5328: clock-generator@69 {/* SI5328 - u20 */
> - reg = <0x69>;
> - /*
> - * Chip has interrupt present connected to PL
> - * interrupt-parent = <&>;
> - * interrupts = <>;
> - */
> - #address-cells = <1>;
> - #size-cells = <0>;
> - #clock-cells = <1>;
> - clocks = <&refhdmi>;
> - clock-names = "xtal";
> - clock-output-names = "si5328";
> -
> - si5328_clk: clk0@0 {
> - reg = <0>;
> - clock-frequency = <27000000>;
> - };
> - };
> + /* SI5328 - u20 */
> };
> /* 5 - 7 unconnected */
> };
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index 18771e868399..eff7c6447087 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -581,25 +581,7 @@ i2c@4 {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <4>;
> - si5328: clock-generator@69 {/* SI5328 - u20 */
> - reg = <0x69>;
> - /*
> - * Chip has interrupt present connected to PL
> - * interrupt-parent = <&>;
> - * interrupts = <>;
> - */
> - #address-cells = <1>;
> - #size-cells = <0>;
> - #clock-cells = <1>;
> - clocks = <&refhdmi>;
> - clock-names = "xtal";
> - clock-output-names = "si5328";
> -
> - si5328_clk: clk0@0 {
> - reg = <0>;
> - clock-frequency = <27000000>;
> - };
> - };
> + /* SI5328 - u20 */
> };
> i2c@5 {
> #address-cells = <1>;
>

Applied.
M