2021-03-09 11:25:58

by Andy Shevchenko

Subject: [PATCH resend v1 2/7] pps: clients: gpio: Use dev_err_probe() to avoid log noise

When GPIO APIs return -EPROBE_DEFER there is no need to print the message,
especially taking into consideration that it may repeat several times.
Use dev_err_probe() to avoid log noise in such cases.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/pps/clients/pps-gpio.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index f89c31aa66f1..78c9680e8063 100644
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -110,19 +110,16 @@ static int pps_gpio_setup(struct platform_device *pdev)
data->gpio_pin = devm_gpiod_get(&pdev->dev,
NULL, /* request "gpios" */
GPIOD_IN);
- if (IS_ERR(data->gpio_pin)) {
- dev_err(&pdev->dev,
- "failed to request PPS GPIO\n");
- return PTR_ERR(data->gpio_pin);
- }
+ if (IS_ERR(data->gpio_pin))
+ return dev_err_probe(&pdev->dev, PTR_ERR(data->gpio_pin),
+ "failed to request PPS GPIO\n");

data->echo_pin = devm_gpiod_get_optional(&pdev->dev,
"echo",
GPIOD_OUT_LOW);
- if (IS_ERR(data->echo_pin)) {
- dev_err(&pdev->dev, "failed to request ECHO GPIO\n");
- return PTR_ERR(data->echo_pin);
- }
+ if (IS_ERR(data->echo_pin))
+ return dev_err_probe(&pdev->dev, PTR_ERR(data->echo_pin),
+ "failed to request ECHO GPIO\n");

if (data->echo_pin) {
ret = of_property_read_u32(np,
--
2.30.1

2021-03-09 12:27:11

by Rodolfo Giometti

Subject: Re: [PATCH resend v1 2/7] pps: clients: gpio: Use dev_err_probe() to avoid log noise

On 09/03/21 12:23, Andy Shevchenko wrote:
> When GPIO APIs return -EPROBE_DEFER there is no need to print the message,
> especially taking into consideration that it may repeat several times.
> Use dev_err_probe() to avoid log noise in such cases.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/pps/clients/pps-gpio.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index f89c31aa66f1..78c9680e8063 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -110,19 +110,16 @@ static int pps_gpio_setup(struct platform_device *pdev)
> data->gpio_pin = devm_gpiod_get(&pdev->dev,
> NULL, /* request "gpios" */
> GPIOD_IN);
> - if (IS_ERR(data->gpio_pin)) {
> - dev_err(&pdev->dev,
> - "failed to request PPS GPIO\n");
> - return PTR_ERR(data->gpio_pin);
> - }
> + if (IS_ERR(data->gpio_pin))
> + return dev_err_probe(&pdev->dev, PTR_ERR(data->gpio_pin),
> + "failed to request PPS GPIO\n");
>
> data->echo_pin = devm_gpiod_get_optional(&pdev->dev,
> "echo",
> GPIOD_OUT_LOW);
> - if (IS_ERR(data->echo_pin)) {
> - dev_err(&pdev->dev, "failed to request ECHO GPIO\n");
> - return PTR_ERR(data->echo_pin);
> - }
> + if (IS_ERR(data->echo_pin))
> + return dev_err_probe(&pdev->dev, PTR_ERR(data->echo_pin),
> + "failed to request ECHO GPIO\n");
>
> if (data->echo_pin) {
> ret = of_property_read_u32(np,
>

Acked-by: Rodolfo Giometti <[email protected]>

--
GNU/Linux Solutions e-mail: [email protected]
Linux Device Driver [email protected]
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti