2021-03-09 19:18:31

by Gao Xiang

Subject: [PATCH] Documentation: sysrq: update description about sysrq crash

After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"),
a crash was not generated by dereferencing a NULL pointer anymore.

Let's update documentation as well to make it less misleading.

Cc: Matthias Kaehlcke <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Jonathan Corbet <[email protected]>
Cc: Zefan Li <[email protected]>
Signed-off-by: Gao Xiang <[email protected]>
---
Documentation/admin-guide/sysrq.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
index 67dfa4c29093..60ce5f5ebab6 100644
--- a/Documentation/admin-guide/sysrq.rst
+++ b/Documentation/admin-guide/sysrq.rst
@@ -90,8 +90,8 @@ Command Function
``b`` Will immediately reboot the system without syncing or unmounting
your disks.

-``c`` Will perform a system crash by a NULL pointer dereference.
- A crashdump will be taken if configured.
+``c`` Will perform a system crash and a crashdump will be taken
+ if configured.

``d`` Shows all locks that are held.

--
2.27.0

2021-03-15 21:49:44

by Jonathan Corbet

Subject: Re: [PATCH] Documentation: sysrq: update description about sysrq crash

Gao Xiang <[email protected]> writes:

> After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"),
> a crash was not generated by dereferencing a NULL pointer anymore.
>
> Let's update documentation as well to make it less misleading.
>
> Cc: Matthias Kaehlcke <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: Zefan Li <[email protected]>
> Signed-off-by: Gao Xiang <[email protected]>
> ---
> Documentation/admin-guide/sysrq.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
> index 67dfa4c29093..60ce5f5ebab6 100644
> --- a/Documentation/admin-guide/sysrq.rst
> +++ b/Documentation/admin-guide/sysrq.rst
> @@ -90,8 +90,8 @@ Command Function
> ``b`` Will immediately reboot the system without syncing or unmounting
> your disks.
>
> -``c`` Will perform a system crash by a NULL pointer dereference.
> - A crashdump will be taken if configured.
> +``c`` Will perform a system crash and a crashdump will be taken
> + if configured.

Makes sense. Applied, thanks.

jon